linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Rob Herring <robh@kernel.org>, Maxim Kutnij <gtk3@inbox.ru>
Cc: linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] This adds a DT binding documentation for the MT6582 SoC
Date: Tue, 28 Dec 2021 16:56:11 +0100	[thread overview]
Message-ID: <331e5b78-2ac7-bca6-061d-85cf25a6bd95@gmail.com> (raw)
In-Reply-To: <YcNhMdN6rzh9yRG1@robh.at.kernel.org>



On 22/12/2021 18:32, Rob Herring wrote:
> On Sun, Dec 19, 2021 at 11:31:34PM +0500, Maxim Kutnij wrote:
>> This adds a DT binding documentation for the MT6582 SoC.
> 
> Please follow the convention used for other commits of these files in
> the subject:
> 
> dt-bindings: mediatek: ...
> 
> (That's true for all commits in the kernel)
> 

I fixed that for you. I also fixed the order of the timer and SoC compatible.

All three patches are now pushed to v5.17-tmp/dts32 [1]
This branch will be renamed to v5.17-next/dts32 after v5.17-rc1 is released.

Hope to see more patches from you to enable other drivers of the SoC.

Thanks!

[1] https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/

>>
>> Signed-off-by: Maxim Kutnij <gtk3@inbox.ru>
>> ---
>>   Documentation/devicetree/bindings/arm/mediatek.yaml           | 4 ++++
>>   .../devicetree/bindings/timer/mediatek,mtk-timer.txt          | 1 +
>>   Documentation/devicetree/bindings/watchdog/mtk-wdt.txt        | 1 +
>>   3 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index 0fa55497b96..fedce0d0f3f 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -26,6 +26,10 @@ properties:
>>             - enum:
>>                 - mediatek,mt2712-evb
>>             - const: mediatek,mt2712
>> +      - items:
>> +          - enum:
>> +              - prestigio,pmt5008-3g
>> +          - const: mediatek,mt6582
>>         - items:
>>             - enum:
>>                 - mediatek,mt6580-evbp1
>> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> index e5c57d6e018..62acdb11aff 100644
>> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> @@ -11,6 +11,7 @@ Required properties:
>>   - compatible should contain:
>>   	For those SoCs that use GPT
>>   	* "mediatek,mt2701-timer" for MT2701 compatible timers (GPT)
>> +	* "mediatek,mt6582-timer" for MT6582 compatible timers (GPT)
>>   	* "mediatek,mt6580-timer" for MT6580 compatible timers (GPT)
>>   	* "mediatek,mt6589-timer" for MT6589 compatible timers (GPT)
>>   	* "mediatek,mt7623-timer" for MT7623 compatible timers (GPT)
>> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> index 0114871f887..a97418c74f6 100644
>> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> @@ -8,6 +8,7 @@ Required properties:
>>   - compatible should contain:
>>   	"mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
>>   	"mediatek,mt2712-wdt": for MT2712
>> +	"mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
>>   	"mediatek,mt6589-wdt": for MT6589
>>   	"mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
>>   	"mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
>> -- 
>> 2.34.1
>>
>>

      reply	other threads:[~2021-12-28 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-19 18:31 [PATCH 1/3] Add initial support for Mediatek mt6582 Maxim Kutnij
2021-12-19 18:31 ` [PATCH 2/3] Add initial support for Prestigio PMT5008 3G tablet Maxim Kutnij
2021-12-19 18:31 ` [PATCH 3/3] This adds a DT binding documentation for the MT6582 SoC Maxim Kutnij
2021-12-22 17:32   ` Rob Herring
2021-12-28 15:56     ` Matthias Brugger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=331e5b78-2ac7-bca6-061d-85cf25a6bd95@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gtk3@inbox.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).