From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752878AbdK3NGK (ORCPT ); Thu, 30 Nov 2017 08:06:10 -0500 Received: from mx144.netapp.com ([216.240.21.25]:4273 "EHLO mx144.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdK3NGH (ORCPT ); Thu, 30 Nov 2017 08:06:07 -0500 X-IronPort-AV: E=Sophos;i="5.45,341,1508828400"; d="scan'208";a="229549507" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anna.Schumaker@netapp.com; Subject: Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4 To: Trond Myklebust , "torvalds@linux-foundation.org" , "rostedt@goodmis.org" CC: "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" References: <20171129215853.20172851@vmware.local.home> <20171129193927.e4248d8a797b90aa03edd0ff@linux-foundation.org> <20171129230528.6955b58a@vmware.local.home> <1512042402.34281.1.camel@primarydata.com> From: Anna Schumaker Message-ID: <33264809-a49c-7c91-842f-153dd0eaf66c@Netapp.com> Date: Thu, 30 Nov 2017 08:05:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1512042402.34281.1.camel@primarydata.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [99.9.112.69] X-ClientProxiedBy: DM5PR2001CA0021.namprd20.prod.outlook.com (10.172.43.31) To DM5PR06MB2475.namprd06.prod.outlook.com (10.168.178.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97451032-20c1-4344-2e1c-08d537f310b0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286);SRVR:DM5PR06MB2475; X-Microsoft-Exchange-Diagnostics: 1;DM5PR06MB2475;3:VHVobv1E6N+cgDOwmDPkf1yF9bZdU5hqNpYGGTnDn1AXcyB0NAifaWfKgxwBFUwuem+PhvriG1DlFDEB6hiPsGPdTI0ONldNkfB+P3fd4AWtyLkCBjFFirhHtaI3KwVxBE3V/mO9kOqVqHmJ/GqjXTF8H54SiHn+tCD6eKL8uILNXRB28dMgH4jjGPgV4nSDDpUPihv4yuL+5njUE5vvzPpAfykhnasEBum9Yxb/GT6T5C+Yl6vwyMjXBBiCUT+D;25:09QeOdCoa93gQpzefVx7VBOh1h6Y/Mhp1ugnQeSEkcbcl/phSllfqvxEvepEj2+WhQOqT9JPhsoj3dMsLEmI2LsQz4yUjbnXkJknY7G4WFOhPO+Fl1zax/Mn2ETjyyMmct9QlChR7EuT5sa7CAareK4rbxgik7E1apNGqUkzf17enlTO68B4MbigD7IfkUzC7gcgz1UHdaL0+CPnZ3GIycYVCCB/jcmWkMkeUA5WYugi73pEDtBGmPNOqHg2K9fmdeG6iTP/1cFYh2HFQPwbHNaAVMQojX8ICCN+VZ1JMMezAKrUfwHqjP9XcsE2uEknFemfCfUi6JXWvDMeopyw1w==;31:/p0t9tgCW6Z014JzxUxvXK0cUpOIOyNoJ28FZYTxUt4FIQCoY4B40z3/CtsJ2GF7BWTnknYqzNmMxI6D3RrO9RBt3vToWrF/JDfea1Zjeki4HW9bnPsNCYX+lsA9aK/nna1QJHeo+wW1PZEamNf2/m29vQWyw/cWZFJuHo/eaI3ftfWu9eJLKVq2+HKCZmHWggGx9wedu2nWNon1MfFTIwgfUKwmJwAph5/zuA2guVc= X-MS-TrafficTypeDiagnostic: DM5PR06MB2475: X-Microsoft-Exchange-Diagnostics: 1;DM5PR06MB2475;20:WxxxSVJKzYBzZgVMjW6i2orN6lNHUG7zx+RM7y/yhh5wShtNm3j/UsQcK/EqFFSnmalp5w0RK4AK7BGSk0swOG02N0iv8L8tnQRvDVCuErrc6a22FvOtBBNxu951ELFl9g0MLMy5zgR/mAq+m2bdIehWEiRu/+UVAIEj2IZ6UXdfMACfIyT5fdFRL+i+vG71Gi2vIoAcBObLXRaQRK2gS5WlOCdBEPQIQKEjisdl/gS/Rasbdc41vajltXfvUCKWLTBpzxODH3uKrGb0/whEDV+lMOrVgmI5MJSZDLC5ADF9YWmcxLOUVERjqvdAPP8e6gGq5bDaTaLonAXpJJ/k/YAeWxrMyFN5II/8QlCD9+beDmnwCkV1CTTJNJiRQj1Y2zX1A0rXesidFA9y28eY6thdser2TB39HBCevFRshbFauGyG0vkouXDBEJNNzgWsFXXuZAPdsHVMMe8F5PpRkDFpjcLwgqzQcuCbgJ7DNoaBtaxIURZjiEwPR7R8JIZH;4:C1EW23qH8zIpAY41d6eHTpsE80V+lMpqgHnPcJjWNPGHxDjhswVqoF8m3rmcim1dZNn4IWNVtQjCzwf98AEdtkE/pgAFGJqnic+AIreLJJClxqWe9viC2LSaQaL1G0XQnrZEIaJRd1lIz6WkTaRhfEpPVrv2RPcGopLJc3lQP7K4udFfaKT0aqfNQovWld2YAbYCin9vRc+M2H4D1C6n7BlWVbe/NlzxtAIc5i6201EffwNQ1I4f8YrhiS1e0SK6ebBawVTfhyWv8fHDK1Yz/w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR06MB2475;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR06MB2475; X-Forefront-PRVS: 05079D8470 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(366004)(376002)(346002)(54094003)(199003)(377424004)(24454002)(189002)(52146003)(83506002)(2501003)(65826007)(8936002)(69596002)(478600001)(81166006)(5660300001)(6486002)(68736007)(2486003)(47776003)(106356001)(97736004)(105586002)(23676004)(81156014)(6512007)(52116002)(53936002)(33646002)(66066001)(64126003)(16526018)(50986010)(76176010)(54356010)(65956001)(189998001)(2906002)(4001150100001)(65806001)(58126008)(93886005)(50466002)(110136005)(54906003)(305945005)(229853002)(3846002)(53416004)(6116002)(316002)(36756003)(31686004)(72206003)(7736002)(2950100002)(6246003)(6666003)(101416001)(53546010)(6506006)(25786009)(575784001)(2201001)(230700001)(31696002)(86362001)(8676002)(4326008)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR06MB2475;H:gouda.nowheycreamery.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA2TUIyNDc1OzIzOmNDY0l3TDNVTURIWXd0L1JuYW1Sb3cvYjc5?= =?utf-8?B?My9RZ3dNSUZlRnlZUVhqYlhWN0lTTkVUc0xUUSsxMDJoamxKUkRrMStneXlr?= =?utf-8?B?MmViTlhXbDlJcXZDVXpta1AxZ040a3hBL2ZkT2Z3ZEtYOGd1UVB3RFBxdWlQ?= =?utf-8?B?TUZkOUt3OG5GZE9wdnhUNGpWVHFzZG9LWXE3Y1ZJNUYxc1MxTmphL1RRWDdw?= =?utf-8?B?VmpYTVBCaERPSmpRWmhYdHdQNFFyQVdmSEVrNjBibkdWUHN5TDAxbXNILzFJ?= =?utf-8?B?ZzlvclJCbGV0ZWdtQWJvMmo2Y3BQdkE1SjhJTkJHS1pBZmF1N1Z0WWd0YnlQ?= =?utf-8?B?UE9mdkNiazRseWVCT1crL2c0K0g1aFNwZWNUckNWZ1NQWGFLZ1M4a3pGL1dw?= =?utf-8?B?dGlFM2Nwd21lb0NQWDZqOGFtODZYNnZnZmcwOEtsM3ZLYXlQdXBiaTg0MlBn?= =?utf-8?B?R21DWFp6emw2NGdzTGFTZitIb1NaenB4N2pGSkRJRXdkS0MvdldFOUdORjdF?= =?utf-8?B?NGZwY0tEMVJmbXY5Q2N4bEJvMWl6dDB5S2RKYWZpc1ZFanFJN2JCVWNXVmlx?= =?utf-8?B?SFIrdjBUVW5kZDMxUFYyZ2duMTNMUXBmS1F1UXNJdlVHOExwOEp5a053YWJG?= =?utf-8?B?L01WMXhDUDRFK1gxQXFlaUdiRUFLd0xIcDRSR1hiazZlNEJ6ZW1oQUpRYkM0?= =?utf-8?B?a1pUQUFsQzFwQ0VKcUdzMXREdkdUMnVjQ3VTV0w3UGNKL0t3bVlna2sxRk91?= =?utf-8?B?Zm9McVZtcU1HNTY5eEgzY1Q1Z01hcW1Xc3IzWEZEaTZZWDFyaTAyTnZ6NkVX?= =?utf-8?B?K1NIdFI4dlJrK3ZkTDB3TU9xMWhCYzhubEE4RHVGZ2tUdWkzZHROWE41Y09p?= =?utf-8?B?eXBtN0hBQ25tR3RIK1pjU2JuRVh2RS9NVU53TlhkZ2dFWHdyRXlBQ2l3QzRr?= =?utf-8?B?SExEb05Xa09VZU9WbkVaZlVZWk9rRTVYRjdIYVBiSUJ1cVNiVGJUUUtVNWpt?= =?utf-8?B?TUpzOGQ0VTFST25QVStkU3ZMUjlmYk85WmU0SzQwWlowT2VCRHNFNkxCa3R3?= =?utf-8?B?SWpFM3F3WlBHeHVYelVTckJwZ3hZNHd0MzByM0llZTdVZzZONElhdjFBV1ly?= =?utf-8?B?bjllcm5lRFBqMHRjRXRJZWNsWHpuWkp4NE1PTkV1czVKdnhxZGZ3ZlZKZGVK?= =?utf-8?B?ZlN3ckxTcGI0eit1blNPNU04OTd4UzR1NXBraGo0bEZtUnRlcS8rdFQ5Q0ZD?= =?utf-8?B?YnhOa210dGRXbGRjNnQ1M0psUEtlZEFGeWNXcU1tRUdmelI1UFRYanh5cWJU?= =?utf-8?B?NzJuQWpVRjhIZmFyRGREbmVnckUyTEdXZ0Zqb2c3aXNGUEsvNGNZNVUzNkhn?= =?utf-8?B?QytRRDZoUzNwQk1zV01lTTNnQWhNRGFmREVyNnpkYWZxdjVFcFlYb2d1MkJP?= =?utf-8?B?Tkhkd1dTd0ZOQ3Z0dzBmYXdRd3NsdGYxbTRoNGpObzErMHAyTW1SOTYwa24v?= =?utf-8?B?VlpVQWZSOUxLTFl4NVU0T2ZyVG1VZTJZTVI1L3dxRmZzdUVPeThRaCtDUFJF?= =?utf-8?B?R29Xb3ZLWU5ZYWltZUFxZE9OT0t5R2NLWXgzVmNWUTF6ZE5ZenlQc2FqcmFP?= =?utf-8?B?UitqZzNETnFVcUxjd1dheFdRYWlPbmJpd2tucElIekppVXdvTUhzYTd4U25C?= =?utf-8?B?WGwvQlhPd2x2ZDVFVUJFSldJQ0hoSnBUL1ZsOUIvR01lYStpb1RsOVJUYUZ1?= =?utf-8?B?S0JrbDNXV1p3N2lTSmc3RUlZNUhET2xSMlhUc05LQ1djMkk0eWhVenFGdUw2?= =?utf-8?B?SWtjSktNemRxTm9CV3drS2EydS9YY0ZvUkR4bHF1V1N5SW1RamdscTJzS3Zi?= =?utf-8?B?cjdBSWlqWmRzMGNRNjdPVnYzOGpZSUNVMmNUSlVqK1ZJdGEvVnVIZ1YraDJy?= =?utf-8?B?SWoxZ3FtVHpTOEZPT1pxYXRSbTZxMmJRSnIwaHExNkhGNWw1T1lJcGJEc2gr?= =?utf-8?B?Ym84RDNMdW82TGwvY3RSNmt5S1pPYVpIV0ZwaEFCTDNSeExkV1ZxVDFBM0ZJ?= =?utf-8?B?NFcyRDdyYVp4cUNHR1hUTXU1VDVORjBTYjlQUW9adUcweTZuMW9uamFTdDc1?= =?utf-8?B?cCtkV0wxbk05ejEzZzlCQ3VCUTNNZmFyUDM3cWlWa1Y4ZHFTOGt4R3FZb3l3?= =?utf-8?Q?U0xn6n+7XoVa7yiaExJKzmD+2zje9pMIFG75LPdH+k=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR06MB2475;6:34m+qHQR3/4SKraPttECOxkEAiou1B4WofST1adSvaMiQT+pMOOQLtGfynZUI5fcJ4UOqhd7PneGhD0rzd1ebzZQrH4HUPPEcG5lxGWn2KK78mma0EruLbRhhqKgtP34Ut6aoPksQzlHti3UY/eeVxeqCAjltirOG2Yj62X9J7WWDm56MN+RgfaJYLpV6rQvrlSSdQ5zuq1aKctr/Oly1AUBmO1a5m3INe+cMjJYwZmaqHuDTwsUut4EkTRlgnJ25GzAqHBKTD8Pr8YXun+6PQ6FIt/2dRDsyzpoYwy6bPrIBt9J/THZclleM3M1DlD5A3LZ1ou1xtVPlKpKrxNitPz1x9rhvxTQ8rW6IDZeqUQ=;5:pSIhTImsalaJ7tH1y8jn/iXCb6pv8zGXjzwyNMhRiNav9JYXxLPs0hWGr5qT353hDyEIqN2YSbDOzqnQKi+XGDBdsj8OrvJ16VDwJAdY5EdFDnJOFMs7x7c3rQAQryUW4H9Ck9wBXaLwTUcYltcCR0H8h0yDatoLhtcjInBIat8=;24:9VEwlGCqAGROfiAkhDiV/GmnKCYJyrDGOZhYLbNdufO5Nn2/TkuezoPDXmhk7g7OcVHeqJogCJrdsFMhiaLLL2k8tz+SV7geCjTMBGzDeJ4=;7:Nz3d1hIOzbisdBhTpt57mRajn5NH9V5gZ0/Ctadl4c6lPvu0rsbdr+BrJPCkLe3rmGLbgglJBAEW9wG1a1HPwgDckL/fblvX479g4cwrc+NFu0BjCYnQ4Z60G23J/0d4EIFZpCNF4SnIG6loVnOgPimMxdlNKLqedPwgzrNqhu2B2Lm1YGLYJl0WFPXDo4ypNKhupeGIjMQnfyUhGogOKF9653B8iJ9kvwJB+DVx09yHz1Px1WHm2Muzz42fGCOw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2017 13:05:43.0449 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97451032-20c1-4344-2e1c-08d537f310b0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR06MB2475 X-OriginatorOrg: netapp.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/2017 06:46 AM, Trond Myklebust wrote: > On Wed, 2017-11-29 at 23:05 -0500, Steven Rostedt wrote: >> On Wed, 29 Nov 2017 19:44:33 -0800 >> Linus Torvalds wrote: >> >> I keep older compilers around to test ftrace before -mfentry was >> introduced. >> >> I wonder if I should just add a config to force the use without >> -mfentry even if the compiler supports it. >> >>> fs/nfs/nfs4state.c | 3 +-- >>> include/linux/nfs4.h | 2 +- >>> 2 files changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c >>> index 54fd56d715a8..9db5d0d57fcb 100644 >>> --- a/fs/nfs/nfs4state.c >>> +++ b/fs/nfs/nfs4state.c >>> @@ -71,8 +71,7 @@ const nfs4_stateid zero_stateid = { >>> }; >>> const nfs4_stateid invalid_stateid = { >>> { >>> - .seqid = cpu_to_be32(0xffffffffU), >>> - .other = { 0 }, >>> + { .seqid = cpu_to_be32(0xffffffffU), .other = { 0 >>> }, }, >> >> I tried this and it failed. >> >>> }, >>> .type = NFS4_INVALID_STATEID_TYPE, >>> }; >>> diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h >>> index 47adac640191..e394ba0cd6c5 100644 >>> --- a/include/linux/nfs4.h >>> +++ b/include/linux/nfs4.h >>> @@ -53,11 +53,11 @@ typedef struct { char data[NFS4_VERIFIER_SIZE]; >>> } nfs4_verifier; >>> >>> struct nfs4_stateid_struct { >>> union { >>> - char data[NFS4_STATEID_SIZE]; >>> struct { >>> __be32 seqid; >>> char other[NFS4_STATEID_OTHER_SIZE]; >>> } __attribute__ ((packed)); >>> + char data[NFS4_STATEID_SIZE]; >> >> But I didn't try this. This looks to be the key. >> >> This works for me. >> >> Tested-by: Steven Rostedt (VMware) >> >> -- Steve >> >>> }; >>> >>> enum { >> >> > > We already have a fix queued up for this issue. It was reported and the > patch hit linux-nfs+linux-kernel almost 2 weeks ago. Anna? I have it queued up, and I was planning to send it this week with some other fixes. Anna >