From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753624AbdBTOBC (ORCPT ); Mon, 20 Feb 2017 09:01:02 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:35028 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752707AbdBTOBA (ORCPT ); Mon, 20 Feb 2017 09:01:00 -0500 Subject: Re: [PATCH v2 1/3] arm64: dts: exynos: Add missing unit name to Exynos7 SoC node References: <1484069912-6534-1-git-send-email-javier@osg.samsung.com> <1484069912-6534-2-git-send-email-javier@osg.samsung.com> <20170110184728.2nff4r634ics4wb3@kozik-lap> Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Andi Shyti , Chanwoo Choi , devicetree@vger.kernel.org, Kukjin Kim , Catalin Marinas , linux-samsung-soc@vger.kernel.org, Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org To: Rob Herring From: Javier Martinez Canillas Message-ID: <33321d4d-645b-d29a-41dc-c5608cd9d096@osg.samsung.com> Date: Mon, 20 Feb 2017 11:00:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, On 01/10/2017 04:55 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 01/10/2017 03:47 PM, Krzysztof Kozlowski wrote: >> On Tue, Jan 10, 2017 at 02:38:30PM -0300, Javier Martinez Canillas wrote: >>> This patch fixes the following DTC warning about a mismatch >>> between a device node reg property and its unit name: >>> >>> Node /soc has a reg or ranges property, but no unit name >>> >>> Signed-off-by: Javier Martinez Canillas >>> --- >>> >>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi >>> index 80aa60e38237..0d2fedc6ac2f 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi >>> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi >>> @@ -69,7 +69,7 @@ >>> method = "smc"; >>> }; >>> >>> - soc: soc { >>> + soc: soc@0 { >> >> This looks unnatural, like a fix just to silence the DTC. Mostly de do >> not enumerate soc node, although there are few exceptions. >> > > Yes, but OTOH arm32 Exynos SoCs just have an empty "ranges" property in their > soc device node (parent and child address space is the same, no translation) > so DTC doesn't complain about the unit address in those. > > But others SoCs DTSI with a non-empty ranges property have an unit name in > their soc nodes, i.e for arm64 and arm32: > > arch/arm64/boot/dts/marvell/berlin4ct.dtsi > > arch/arm/boot/dts/da850.dtsi > >> I would prefer ignore the warning... however I am happy to hear other opinions. >> > > If is wrong/unnatural to have addresses for soc nodes then I think DTC should > be patched to ignore these (like it will be the case for the OPP nodes AFAIU). > Any comments about this? >> Best regards, >> Krzysztof >> > > Best regards, > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America