From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Maxime Ripard <mripard@kernel.org>
Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc
Date: Fri, 17 Jan 2020 19:18:58 +0100 [thread overview]
Message-ID: <3332569.R56niFO833@jernej-laptop> (raw)
In-Reply-To: <20200117181427.hy7qsyxwomsl3v2q@gilmour.lan>
Dne petek, 17. januar 2020 ob 19:14:27 CET je Maxime Ripard napisal(a):
> On Wed, Jan 15, 2020 at 08:34:41PM +0100, Jernej Skrabec wrote:
> > Tanix TX6 has 32 GiB eMMC. Add a node for it.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> >
> > .../dts/allwinner/sun50i-h6-tanix-tx6.dts | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts index
> > 83e6cb0e59ce..8cbf4e4a761e 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > @@ -31,6 +31,13 @@ hdmi_con_in: endpoint {
> >
> > };
> >
> > };
> >
> > + reg_vcc1v8: vcc1v8 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc1v8";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + };
> > +
> >
> > reg_vcc3v3: vcc3v3 {
> >
> > compatible = "regulator-fixed";
> > regulator-name = "vcc3v3";
> >
> > @@ -78,6 +85,15 @@ &mmc0 {
> >
> > status = "okay";
> >
> > };
> >
> > +&mmc2 {
> > + vmmc-supply = <®_vcc3v3>;
> > + vqmmc-supply = <®_vcc1v8>;
> > + non-removable;
> > + cap-mmc-hw-reset;
> > + bus-width = <8>;
> > + status = "okay";
> > +};
> > +
> >
> > &ohci0 {
> >
> > status = "okay";
> >
> > };
> >
> > @@ -86,6 +102,10 @@ &ohci3 {
> >
> > status = "okay";
> >
> > };
> >
> > +&pio {
> > + vcc-pc-supply = <®_vcc1v8>;
> > +};
> > +
>
> Can you list all of the regulators for the H6 while you're at it (in a
> preliminary patch, ideally)?
Not sure what you mean. This box has only fixed regulators. I deducted above
from the fact that port C is mostly dedicated to eMMC, so it has to use same
regulator as vqmmc. Other than that, I don't know.
Best regards,
Jernej
next prev parent reply other threads:[~2020-01-17 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 19:34 [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc Jernej Skrabec
2020-01-16 12:27 ` Maxime Ripard
2020-01-16 16:29 ` Jernej Škrabec
2020-01-17 18:14 ` Maxime Ripard
2020-01-17 18:18 ` Jernej Škrabec [this message]
2020-01-22 17:42 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3332569.R56niFO833@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).