linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Daniel Mack <daniel@zonque.org>
Cc: Tom Gundersen <teg@jklm.no>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux API <linux-api@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	John Stultz <john.stultz@linaro.org>, Tejun Heo <tj@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Ryan Lortie <desrt@desrt.ca>, Bastien Nocera <hadess@hadess.net>,
	David Herrmann <dh.herrmann@gmail.com>,
	Djalal Harouni <tixxdz@opendz.org>,
	Simon McVittie <simon.mcvittie@collabora.co.uk>,
	"alban.crequy" <alban.crequy@collabora.co.uk>,
	"javier.martinez" <javier.martinez@collabora.co.uk>
Subject: Re: kdbus: add header file
Date: Thu, 30 Oct 2014 13:03:44 +0100	[thread overview]
Message-ID: <3334170.rJW8YMf1Nv@wuerfel> (raw)
In-Reply-To: <5452269A.9050003@zonque.org>

On Thursday 30 October 2014 12:52:58 Daniel Mack wrote:
> On 10/30/2014 12:26 PM, Arnd Bergmann wrote:
> > On Thursday 30 October 2014 12:02:39 Tom Gundersen wrote:
> 
> >> The nice thing about enums is of course that it helps with debugging
> >> as gdb can show the string representation rather than the number,
> >> because in contrast to #defines, an enum is something the compliler
> >> knows about.
> > 
> > This doesn't get passed as an enum in user space though, and when debugging
> > the kernel it only helps within one function.
> 
> Hmm, this is the header exported to userspace, so having enums in would
> make our lives easier, right?

My point was that you never use the enum by type and the only place in
user space where it's referenced would be something like

	ret = ioctl(fd, KDBUS_CMD_BUS_MAKE, &make);

In the debugger, you will see the source line here. If you trace into the
glibc ioctl function, you no longer know the type because that just
has an 'int'.

> Hence, for now, I'd propose we keep it the way it is, and add new ioctls
> with defines once they are implemented. Are you okay with this? I'll add
> a comment to the file to give a heads-up.

It's certainly not a show-stopped, but I have yet to see a good reason
why it would help anyone.

	Arnd

  reply	other threads:[~2014-10-30 12:03 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 22:00 [PATCH 00/12] Add kdbus implementation Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add documentation Greg Kroah-Hartman
2014-10-30 12:20   ` Peter Meerwald
2014-11-02  1:29     ` Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add header file Greg Kroah-Hartman
2014-10-30  8:20   ` Arnd Bergmann
2014-10-30 11:02     ` Tom Gundersen
2014-10-30 11:26       ` Arnd Bergmann
2014-10-30 11:52         ` Daniel Mack
2014-10-30 12:03           ` Arnd Bergmann [this message]
2014-10-31 10:03             ` Daniel Mack
2014-10-29 22:00 ` kdbus: add driver skeleton, ioctl entry points and utility functions Greg Kroah-Hartman
2014-10-30  3:50   ` Eric W. Biederman
2014-10-30 23:45   ` Thomas Gleixner
2014-10-31  0:23     ` Jiri Kosina
2014-10-31  0:42       ` Thomas Gleixner
2014-10-29 22:00 ` kdbus: add connection pool implementation Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add connection, queue handling and message validation code Greg Kroah-Hartman
     [not found]   ` <87k33iw759.fsf@x220.int.ebiederm.org>
2014-10-30  3:55     ` Andy Lutomirski
2014-10-30  9:06       ` Djalal Harouni
2014-10-29 22:00 ` kdbus: add code to gather metadata Greg Kroah-Hartman
2014-10-29 22:33   ` Andy Lutomirski
2014-10-30  0:13     ` Andy Lutomirski
2014-10-30  8:45       ` Daniel Mack
2014-10-30 14:07         ` Andy Lutomirski
2014-10-30 15:54           ` Daniel Mack
2014-10-30 21:01             ` Andy Lutomirski
2014-11-01 11:05               ` Daniel Mack
2014-11-01 16:19                 ` Andy Lutomirski
2014-11-03 12:00                   ` Simon McVittie
2014-11-03 17:05                     ` Andy Lutomirski
2014-10-30  8:09     ` Daniel Mack
2014-10-29 22:00 ` kdbus: add code for notifications and matches Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add code for buses, domains and endpoints Greg Kroah-Hartman
2014-10-30  3:59   ` Eric W. Biederman
2014-10-30  9:58     ` Djalal Harouni
2014-10-30 12:15       ` Eric W. Biederman
2014-10-30 14:48         ` Djalal Harouni
2014-10-30 14:58           ` Andy Lutomirski
2014-10-30 18:08             ` Djalal Harouni
2014-10-30 18:46               ` Simon McVittie
2014-11-05 19:59                 ` Djalal Harouni
2014-10-30 20:37               ` Andy Lutomirski
     [not found]                 ` <m2ublh$5h7$2@ger.gmane.org>
2014-10-30 22:00                   ` Andy Lutomirski
2014-10-30 23:38   ` How Not To Use kref (was Re: kdbus: add code for buses, domains and endpoints) Al Viro
2014-10-31 18:00     ` Linus Torvalds
2014-10-31 19:56       ` Al Viro
2014-11-04  9:11     ` David Herrmann
2014-10-31  1:39   ` kdbus: add code for buses, domains and endpoints Al Viro
2014-10-31  9:55     ` Daniel Mack
2014-10-29 22:00 ` kdbus: add name registry implementation Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add policy database implementation Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add Makefile, Kconfig and MAINTAINERS entry Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add selftests Greg Kroah-Hartman
2014-10-30  8:31   ` Arnd Bergmann
2014-11-14  3:42   ` Michael Ellerman
2014-11-14  8:56     ` Daniel Mack
2014-10-29 22:15 ` [PATCH 00/12] Add kdbus implementation Greg KH
2014-10-30  4:04   ` Eric W. Biederman
2014-10-30  7:12     ` Daniel Mack
2014-10-29 22:15 ` Andy Lutomirski
2014-10-29 22:27   ` Greg Kroah-Hartman
2014-10-29 22:34     ` Andy Lutomirski
2014-10-30  2:27     ` Andy Lutomirski
2014-10-30  4:20       ` Eric W. Biederman
2014-10-30 10:15         ` Tom Gundersen
2014-10-30 12:02           ` Eric W. Biederman
2014-10-30 13:48           ` Andy Lutomirski
2014-10-29 22:19 ` Andy Lutomirski
2014-10-29 22:25   ` Greg Kroah-Hartman
2014-10-29 22:28     ` Andy Lutomirski
2014-10-29 22:36       ` Andy Lutomirski
2014-10-30  7:44       ` Daniel Mack
2014-11-05 14:34   ` Daniel Mack
2014-10-29 23:00 ` Jiri Kosina
2014-10-29 23:11   ` Greg Kroah-Hartman
2014-10-29 23:12     ` Greg Kroah-Hartman
2014-10-29 23:24     ` Jiri Kosina
2014-10-29 23:26       ` Jiri Kosina
2014-10-29 23:34         ` Greg Kroah-Hartman
2014-10-29 23:40       ` Greg Kroah-Hartman
2014-10-29 23:55         ` Andy Lutomirski
2014-10-30 11:52           ` Tom Gundersen
2014-10-30 12:28             ` Simon McVittie
2014-10-30 13:59             ` Andy Lutomirski
2014-10-30 20:28               ` Alex Elsayed
2014-10-30  9:51         ` Karol Lewandowski
2014-10-30 10:44           ` Karol Lewandowski
2014-10-30 14:47             ` Greg Kroah-Hartman
2014-10-30 19:55               ` Karol Lewandowski
2014-10-30 20:24                 ` Greg Kroah-Hartman
2014-10-31 11:15                   ` Karol Lewandowski
2014-10-30 23:13                 ` One Thousand Gnomes
2014-10-31 10:58                   ` Karol Lewandowski
2014-10-30 23:39                 ` Paul Moore
2014-10-31 14:21                   ` Karol Lewandowski
     [not found]                     ` <1414773397-26490-1-git-send-email-k.lewandowsk@samsung.com>
     [not found]                       ` <20141107180120.GA15387@kroah.com>
2014-11-09  0:07                         ` [RFC PATCH 0/5] kdbus: add support for lsm Karol Lewandowski
     [not found]                       ` <1414773397-26490-2-git-send-email-k.lewandowsk@samsung.com>
2014-11-17  1:47                         ` [PATCH 1/5] kdbus: extend structures with security pointer " Karol Lewandowski
2014-11-17 18:37                           ` Greg KH
2014-11-02  1:21   ` [PATCH 00/12] Add kdbus implementation Greg Kroah-Hartman
2014-11-03 14:38     ` One Thousand Gnomes
2014-10-30  8:33 ` Arnd Bergmann
2014-10-30 16:17   ` Greg Kroah-Hartman
2014-11-21  5:02 [PATCH v2 00/13] " Greg Kroah-Hartman
2014-11-21  5:02 ` kdbus: add header file Greg Kroah-Hartman
2014-11-21  8:34   ` Harald Hoyer
2014-11-21  8:55     ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3334170.rJW8YMf1Nv@wuerfel \
    --to=arnd@arndb.de \
    --cc=alban.crequy@collabora.co.uk \
    --cc=daniel@zonque.org \
    --cc=desrt@desrt.ca \
    --cc=dh.herrmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hadess@hadess.net \
    --cc=javier.martinez@collabora.co.uk \
    --cc=john.stultz@linaro.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=simon.mcvittie@collabora.co.uk \
    --cc=teg@jklm.no \
    --cc=tixxdz@opendz.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).