From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932468AbcL0Ngd (ORCPT ); Tue, 27 Dec 2016 08:36:33 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:35243 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754785AbcL0NgT (ORCPT ); Tue, 27 Dec 2016 08:36:19 -0500 X-AuditID: b6c32a2d-f79a76d0000074b4-40-58626e4015ad From: Bartlomiej Zolnierkiewicz To: Pankaj Dubey Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, jingoohan1@gmail.com, Niyas Ahmed S T , krzk@kernel.org, jh80.chung@samsung.com, kgene@kernel.org, alim.akhtar@samsung.com, bhelgaas@google.com, sanath@samsung.com Subject: Re: [PATCH] PCI: exynos: refactor exynos pcie driver Date: Tue, 27 Dec 2016 14:35:54 +0100 Message-id: <3335251.c58Y1Zf7PB@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKKsWRmVeSWpSXmKPExsWy7bCmhq5DXlKEwfYGdYsH87axWSxpyrC4 8auN1WLFl5nsFv2PXzNbnD+/gd1i0+NrrBaXd81hszg77zibxYzz+5gsnkx5xGqxaOsXdotp 69YxO/B67Jx1l91jwaZSj02rOtk8Ni+p9+jbsorR4/MmuQC2KC6blNSczLLUIn27BK6Mxf/P sBXcZK+4+fwBSwPjArYuRk4OCQETiYPbvjBC2GISF+6tB4pzcQgJLGWUuHt1FyuE084k8W/6 VBaYjmXLHjNCJJYzSjxZsRWq5SujxPmOG8wgVWwCVhIT21eBzRUR0JbovHwPbBSzwCkmiT/t O8GKhAVsJU537WUCsVkEVCXO390MFucV0JT42zwVLC4q4CWxZV87mM0p4Cnxa9ZCdogaQYkf k++BncQsIC+xb/9UVghbR+LssXVg50kIXGOXaPp3FKiBA8iRldh0gBniBReJlx/nQT0tLPHq +BZ2CFta4u/SW1Dx6YwS239LQMzZzCixavcEqCJricPHL0It45Po/f2ECWI+r0RHmxBEiYfE rofvWSFsR4lpS6dDQ2gOo8SVqwvZJzDKz0LywywkP8xC8sMCRuZVjGKpBcW56anFpgVGesWJ ucWleel6yfm5mxjBiUlLdwfjlwXehxgFOBiVeHh/LE+MEGJNLCuuzD3EKMHBrCTC+yQjKUKI NyWxsiq1KD++qDQntfgQozQHi5I474IK6wghgfTEktTs1NSC1CKYLBMHp1QD48JD4XsqFrZ0 xd4JEhfqkdb3+xRyu+iss/bxPQUfLkhNKbvEnfV1GfeWg+Lvlc+zSr3YsfTyvazWJZP8pmi0 qe7tsTYSWH77aGvlt3z5BVc0Xnwo/uqxY19I9bHy1TWrT95Xco8oZuBUisrKLVNjMtvDYPze 7cPTt3l3nOYpz44x/ywRlHhEUYmlOCPRUIu5qDgRANUxy2NIAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jAV2HvKQIg/fvxSwezNvGZrGkKcPi xq82VosVX2ayW/Q/fs1scf78BnaLTY+vsVpc3jWHzeLsvONsFjPO72OyeDLlEavFoq1f2C2m rVvH7MDrsXPWXXaPBZtKPTat6mTz2Lyk3qNvyypGj8+b5ALYotxsMlITU1KLFFLzkvNTMvPS bZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWsfj/GbaCm+wVN58/ YGlgXMDWxcjJISFgIrFs2WNGCFtM4sK99UBxLg4hgaWMEm+WnWSHcL4ySiyefooVpIpNwEpi YvsqsA4RAW2Jzsv3WEGKmAVOMUlsb+pgB0kIC9hKnO7aywRiswioSpy/u5kZxOYV0JT42zwV LC4q4CWxZV87mM0p4Cnxa9ZCqG3zGCWuvLzMBtEgKPFj8j0WEJtZQF5i3/6prBC2lsT6nceZ JjAKzEJSNgtJ2SwkZQsYmVcxSqQWJBcUJ6XnGuWllusVJ+YWl+al6yXn525iBEfqM+kdjId3 uR9iFOBgVOLhjdiYGCHEmlhWXJl7iFGCg1lJhPdJRlKEEG9KYmVValF+fFFpTmrxIUZToA8n MkuJJucDk0heSbyhibmJubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2MO833 Ldj8Muy3XbT9jbU/VXcYuPqtMKvn096hw7GpmeuD4iurZJnqhtX2TeKFR7WVyt2bnHemThBf t6lFwlmt4Q9rvlSma4pJdYqBgNT1bquy90XFHT9y33wIyTjybJbUbvE1AlPnLngczLnW/MeN 2ceu2/FqCtoUHTyl3/eePe9v5t4ZSSxKLMUZiYZazEXFiQC7eQtt6gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161227133600epcas5p3fa3f3976ea415db47375658998a7f575 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20161223105411epcas1p3727f726e757ec6c6d7bff04a9af40077 X-RootMTR: 20161223105411epcas1p3727f726e757ec6c6d7bff04a9af40077 References: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, December 23, 2016 04:26:27 PM Pankaj Dubey wrote: > From: Niyas Ahmed S T > > Currently Exynos PCIe driver is only supported for Exynos5440 SoC. > This patch does refactoring of Exynos PCIe driver to extend support > for other Exynos SoC. > > Following are the main changes done via this patch: > 1) It adds separate structs for memory, clock resources. > 2) It add exynos_pcie_ops struct which will allow us to support the > differences in resources in different Exynos SoC. > > No functional change intended. > > Signed-off-by: Niyas Ahmed S T > Signed-off-by: Pankaj Dubey I would also like to see the explanation for 1) (as already requested by Jingoo). Otherwise it all looks fine to me: Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics