RE: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

["jeff_chang(張世佳)" <jeff_chang@richtek.com>]

Dear Jarsolav:

Thanks for your reply.

I will send a new patch later.


Thanks & BRs
Jeff Chang
Tel 886-3-5526789 Ext 2357
14F, No. 8, Taiyuen 1st st., Zhubei City,
Hsinchu County, Taiwan 30288



-----Original Message-----
From: Jaroslav Kysela [mailto:perex@perex.cz]
Sent: Thursday, December 12, 2019 6:36 PM
To: Jeff Chang <richtek.jeff.chang@gmail.com>; lgirdwood@gmail.com
Cc: broonie@kernel.org; tiwai@suse.com; matthias.bgg@gmail.com; alsa-devel@alsa-project.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; jeff_chang(張世佳) <jeff_chang@richtek.com>
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

Dne 12. 12. 19 v 10:12 Jeff Chang napsal(a):
> +static const struct snd_kcontrol_new mt6660_component_snd_controls[] = {
> +SOC_SINGLE_EXT_TLV("Digital Volume", MT6660_REG_VOL_CTRL, 0, 255,
> +   1, snd_soc_get_volsw, mt6660_component_put_volsw,
> +   vol_ctl_tlv),
> +SOC_SINGLE_EXT("WDT Switch", MT6660_REG_WDT_CTRL, 7, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("Hard_Clip Switch", MT6660_REG_HCLIP_CTRL, 8, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("Clip Switch", MT6660_REG_SPS_CTRL, 0, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("BoostMode", MT6660_REG_BST_CTRL, 0, 3, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("DRE Switch", MT6660_REG_DRE_CTRL, 0, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("DC_Protect Switch",
> +MT6660_REG_DC_PROTECT_CTRL, 3, 1, 0,
> +snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("audio input selection", MT6660_REG_DATAO_SEL, 6, 3, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("Data Output Left Channel Selection",
> +       MT6660_REG_DATAO_SEL, 3, 7, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("Data Output Right Channel Selection",
> +       MT6660_REG_DATAO_SEL, 0, 7, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +/* for debug purpose */
> +SOC_SINGLE_EXT("HPF_AUD_IN Switch", MT6660_REG_HPF_CTRL, 0, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("AUD_LOOP_BACK Switch", MT6660_REG_PATH_BYPASS, 4, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("Mute Switch", MT6660_REG_SYSTEM_CTRL, 1, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("Bypass CS Comp Switch", MT6660_REG_PATH_BYPASS, 2, 1, 0,
> +       snd_soc_get_volsw, mt6660_component_put_volsw),
> +SOC_SINGLE_EXT("T0_SEL", MT6660_REG_CALI_T0, 0, 7, 0,
> +       snd_soc_get_volsw, NULL),
> +SOC_SINGLE_EXT("Chip_Rev", SND_SOC_NOPM, 0, 16, 0,
> +       mt6660_component_get_volsw, NULL),

The control names looks really strange like always for the ASoC tree. We should talk about a standardization here. At least unify spaces, underscores and such characters and abbreviations.

Thanks,
Jaroslav

--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!