From: Icenowy Zheng <uwu@icenowy.me>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 2/2] ASoC: Intel: Skylake: try to get NHLT blob with PCM params as fallback
Date: Mon, 08 Aug 2022 01:26:48 +0800 [thread overview]
Message-ID: <3346b62c3cd7e07766457c9140849a31d6d8775c.camel@icenowy.me> (raw)
In-Reply-To: <4208aece-0aea-ba86-9a00-9e217546e1dd@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3339 bytes --]
在 2022-08-02星期二的 12:30 +0200,Cezary Rojewski写道:
> On 2022-07-25 1:10 PM, Icenowy Zheng wrote:
> > Switching to use pipeline parameters to get NHLT blob breaks audio
> > on
> > HP Chromebook 13 G1 (at least with MrChromeBox firmware).
> >
> > Fix this by retrying to get NHLT blob with PCM parameters (which is
> > the
> > old behavior) if pipeline parameters fail.
> >
> > Fixes: 87b265260046 ("ASoC: Intel: Skylake: Select proper format
> > for NHLT blob")
> > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>
> Hello,
>
>
> Could you share the NHLT file from your platform plus the format used
> by
> the cras/userspace tool? Did you try playing over simple aplay tool
> instead?
I tried 48000Hz 2ch 32bit with speaker-test.
Attached is /sys/firmware/acpi/tables/NHLT.
>
>
> > sound/soc/intel/skylake/skl-topology.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/sound/soc/intel/skylake/skl-topology.c
> > b/sound/soc/intel/skylake/skl-topology.c
> > index 19994ec8bba1..3d5a3ee1c82c 100644
> > --- a/sound/soc/intel/skylake/skl-topology.c
> > +++ b/sound/soc/intel/skylake/skl-topology.c
> > @@ -1858,6 +1858,15 @@ static int
> > skl_tplg_be_fill_pipe_params(struct snd_soc_dai *dai,
> > pipe_fmt->bps, params-
> > >s_cont,
> > pipe_fmt->channels,
> > pipe_fmt->freq,
> > pipe->direction, dev_type);
> > + if (!cfg) {
> > + /* Retry with PCM parameters, as the old behavior
> > */
>
> Drop the "old behavior" - most of the readers are not aware of what
> that
> actually means.
>
> > + cfg = intel_nhlt_get_endpoint_blob(dai->dev, skl-
> > >nhlt,
> > + mconfig->vbus_id,
> > link_type,
> > + params->s_fmt,
> > params->s_cont,
> > + params->ch, params-
> > >s_freq,
> > + params->stream,
> > dev_type);
> > + }
> > +
> > if (cfg) {
> > mconfig->formats_config[SKL_PARAM_INIT].caps_size =
> > cfg->size;
> > mconfig->formats_config[SKL_PARAM_INIT].caps = (u32
> > *)&cfg->caps;
> > @@ -1866,6 +1875,8 @@ static int
> > skl_tplg_be_fill_pipe_params(struct snd_soc_dai *dai,
> > mconfig->vbus_id, link_type, params-
> > >stream,
> > pipe_fmt->channels, pipe_fmt->freq,
> > pipe_fmt->bps);
> > + dev_err(dai->dev, "PCM: ch %d, freq %d, fmt %d\n",
> > + params->ch, params->s_freq, params->s_fmt);
> > return -EINVAL;
> > }
> >
[-- Attachment #2: NHLT --]
[-- Type: application/octet-stream, Size: 6736 bytes --]
next prev parent reply other threads:[~2022-08-07 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 11:10 [PATCH 1/2] ASoC: Intel: Skylake: fix error message of NHLT blob selection Icenowy Zheng
2022-07-25 11:10 ` [PATCH 2/2] ASoC: Intel: Skylake: try to get NHLT blob with PCM params as fallback Icenowy Zheng
2022-08-02 10:30 ` Cezary Rojewski
2022-08-07 17:26 ` Icenowy Zheng [this message]
2022-08-16 19:08 ` Cezary Rojewski
2022-08-17 12:40 ` Mark Brown
2022-08-17 12:48 ` Icenowy Zheng
2022-08-17 13:19 ` Cezary Rojewski
2022-08-18 9:25 ` Icenowy Zheng
2022-08-18 9:54 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3346b62c3cd7e07766457c9140849a31d6d8775c.camel@icenowy.me \
--to=uwu@icenowy.me \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).