From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Bernard <bernard@vivo.com>, Zhang Rui <rui.zhang@intel.com>,
Amit Kucheria <amitk@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: Re: [Resend][PATCH] drivers/thermal: optimize the for circle to run a bit fast
Date: Mon, 26 Oct 2020 19:35:18 +0100 [thread overview]
Message-ID: <33587c80-d273-acf3-2d95-65d757b188df@linaro.org> (raw)
In-Reply-To: <ANAAuADPDd5Q*8KfRTwcp4ps.1.1603676964376.Hmail.bernard@vivo.com>
On 26/10/2020 02:49, Bernard wrote:
> Function thermal_zone_device_register, in the for circle, if the
> first if branch set the count bit in tz->trips_disabled, there is
> no need to set in the other if branch again.
> This change is to make the code run a bit fast and readable.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
> drivers/thermal/thermal_core.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index c6d74bc1c90b..03577794eea3 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1446,10 +1446,14 @@ thermal_zone_device_register(const char *type, int trips, int mask,
> goto release_device;
>
> for (count = 0; count < trips; count++) {
> - if (tz->ops->get_trip_type(tz, count, &trip_type))
> + if (tz->ops->get_trip_type(tz, count, &trip_type)) {
> set_bit(count, &tz->trips_disabled);
> - if (tz->ops->get_trip_temp(tz, count, &trip_temp))
> + continue;
> + }
> + if (tz->ops->get_trip_temp(tz, count, &trip_temp)) {
> set_bit(count, &tz->trips_disabled);
> + continue;
> + }
> /* Check for bogus trip points */
> if (trip_temp == 0)
> set_bit(count, &tz->trips_disabled);
What about ?
if (tz->ops->get_trip_type(tz, count, &trip_type) ||
tz->ops->get_trip_temp(tz, count, &trip_temp) ||
!trip_temp)
set_bit(count, &tz->trips_disabled);
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-10-26 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 1:49 [Resend][PATCH] drivers/thermal: optimize the for circle to run a bit fast Bernard
2020-10-26 18:35 ` Daniel Lezcano [this message]
2020-10-27 1:19 ` Bernard
2020-10-27 8:47 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33587c80-d273-acf3-2d95-65d757b188df@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=bernard@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).