From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Sudeep Holla <sudeep.holla@arm.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH 0/3] cpuidle: Rework the handling of the poll state
Date: Tue, 29 Aug 2017 09:13:20 +0200 [thread overview]
Message-ID: <335d33b3-832a-1588-c007-16110dbef33e@linaro.org> (raw)
In-Reply-To: <8432156.DIvYQkV4Qe@aspire.rjw.lan>
On 28/08/2017 23:17, Rafael J. Wysocki wrote:
> On Thursday, August 24, 2017 11:48:19 AM CEST Sudeep Holla wrote:
>>
>> On 23/08/17 22:18, Rafael J. Wysocki wrote:
>>> Hi,
>>>
>>> On x86 the fist idle state is a polling one, but the way it is set up is far
>>> from straightforward and then it is avoided by governors in rather somewhat
>>> convoluted fashion.
>>>
>>> Make this more clear by explicitly flagging that state as "polling" and
>>> checking its flag where it needs to be avoided instead of using
>>> arch-dependent numbering of idle states (patch [1/3]), move the
>>> polling state code from driver.c to a separate C file (patch [2/3]) and
>>> move the initialization of it from the core to the relevant cpuidle drivers -
>>> ACPI and intel_idle (patch [3/3]).
>>>
>>
>> Tested this on ARM64 platform(both DT and ACPI/LPI) and everything
>> continues to work fine.
>> Tested-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Thanks Sudeep!
>
> I haven't seen any more comments on this which I'm taking as a green light for
> it, so I'm going to queue it up for 4.14.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2017-08-29 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 21:18 [PATCH 0/3] cpuidle: Rework the handling of the poll state Rafael J. Wysocki
2017-08-23 21:19 ` [PATCH 1/3] cpuidle: Eliminate the CPUIDLE_DRIVER_STATE_START symbol Rafael J. Wysocki
2017-08-23 21:21 ` [PATCH 2/3] cpuidle: Move polling state initialization code to separate file Rafael J. Wysocki
2017-08-23 21:22 ` [PATCH 3/3] cpuidle: Make drivers initialize polling state Rafael J. Wysocki
2017-08-24 9:48 ` [PATCH 0/3] cpuidle: Rework the handling of the poll state Sudeep Holla
2017-08-28 21:17 ` Rafael J. Wysocki
2017-08-29 7:13 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=335d33b3-832a-1588-c007-16110dbef33e@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).