From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
vkoul@kernel.org, Devicetree List <devicetree@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
bgoswami@codeaurora.org, Takashi Iwai <tiwai@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
rohitkr@codeaurora.org, srini@kernel.org
Subject: Re: [alsa-devel] [PATCH v3 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime_buffer()
Date: Fri, 16 Nov 2018 09:21:42 +0000 [thread overview]
Message-ID: <336ad4dd-6046-7386-4080-d3061d04d8c2@linaro.org> (raw)
In-Reply-To: <CAEnQRZBGQX7C2=fUr-6et6Wh=fOgX3nB=eFYG959XiuDMqbaKg@mail.gmail.com>
Thanks for your comments!
On 16/11/18 07:18, Daniel Baluta wrote:
> One minor comment:
>
> <snip>
>
>> struct snd_compr_ops *ops;
>> + struct snd_dma_buffer *dma_buffer_p;
> I don't think it is necessary to encode the type inside the name variable
> So, dma_buffer would sounds better to me then dma_buffer_p;
>
>> void *buffer;
> It is also consistent with this ^
>
> <snip>
>> +static inline void snd_compr_set_runtime_buffer(
>> + struct snd_compr_stream *substream,
>> + struct snd_dma_buffer *bufp)
> Also buf instead of bufp here.
TBH, I followed what ./include/sound/pcm.h does!
--srini
next prev parent reply other threads:[~2018-11-16 9:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 18:13 [PATCH v3 0/5] ASoC: qdsp6: add compress offload support Srinivas Kandagatla
2018-11-15 18:13 ` [PATCH v3 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime_buffer() Srinivas Kandagatla
2018-11-16 7:18 ` [alsa-devel] " Daniel Baluta
2018-11-16 9:21 ` Srinivas Kandagatla [this message]
2018-11-15 18:13 ` [PATCH v3 2/5] ALSA: compress: make use of runtime buffer for copy Srinivas Kandagatla
2018-11-15 18:13 ` [PATCH v3 3/5] ASoC: q6asm-dai: dt-bindings: Add support to compress dais Srinivas Kandagatla
2018-11-15 18:13 ` [PATCH v3 4/5] ASoC: qdsp6: q6asm: add support to MP3 format Srinivas Kandagatla
2018-12-14 12:44 ` Applied "ASoC: qdsp6: q6asm: add support to MP3 format" to the asoc tree Mark Brown
2018-11-15 18:13 ` [PATCH v3 5/5] ASoC: qdsp6: q6asm-dai: Add support to compress offload Srinivas Kandagatla
2018-12-14 12:44 ` Applied "ASoC: qdsp6: q6asm-dai: Add support to compress offload" to the asoc tree Mark Brown
2018-11-30 12:22 ` [PATCH v3 0/5] ASoC: qdsp6: add compress offload support Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336ad4dd-6046-7386-4080-d3061d04d8c2@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).