From: Logan Gunthorpe <logang@deltatee.com>
To: Nadav Amit <namit@vmware.com>
Cc: Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros
Date: Wed, 28 Nov 2018 17:49:38 -0700 [thread overview]
Message-ID: <336cf7d8-6495-b112-8d3a-c146222fda78@deltatee.com> (raw)
In-Reply-To: <5682CCB4-B7D3-4DDC-81BB-2D4DCE968A3D@vmware.com>
On 2018-11-28 5:38 p.m., Nadav Amit wrote:
> So what’s your take? Would you think this patch is still needed? Should it
> only be enabled automatically for distcc and not for distcc-pump?
Not sure. The patch will probably slow things down a lot (seeing
assembly is always done locally and there are twice as many compile
steps) and will create some confusion once it's possible to disable it
for the new versions. Maybe hold off and see if anyone else complains?
I don't really know how you'd detect whether pump is in use or not and
I'm uncertain as to whether any of the auto detection can actually be
made to be reliable.
Logan
next prev parent reply other threads:[~2018-11-29 0:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 15:02 [PATCH 0/2] x86: Asm macros fixes Nadav Amit
2018-11-12 15:02 ` [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros Nadav Amit
2018-11-13 11:30 ` Ingo Molnar
2018-11-13 17:55 ` Nadav Amit
2018-11-13 18:34 ` Nadav Amit
2018-11-14 7:29 ` Logan Gunthorpe
2018-11-14 17:46 ` Nadav Amit
2018-11-15 1:19 ` Logan Gunthorpe
2018-11-15 1:57 ` Nadav Amit
2018-11-15 2:00 ` Logan Gunthorpe
2018-11-28 23:09 ` Logan Gunthorpe
2018-11-29 0:38 ` Nadav Amit
2018-11-29 0:49 ` Logan Gunthorpe [this message]
2018-11-29 1:31 ` Nadav Amit
2018-11-29 16:43 ` Logan Gunthorpe
2018-12-01 6:29 ` Nadav Amit
2018-11-12 15:02 ` [PATCH 2/2] x86: set a dependency on macros.S Nadav Amit
2018-11-13 11:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336cf7d8-6495-b112-8d3a-c146222fda78@deltatee.com \
--to=logang@deltatee.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).