From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@linux.ie>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Mukesh Ojha <mojha@codeaurora.org>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH v2] drm: rcar-du: fix possible object reference leak
Date: Mon, 8 Apr 2019 18:38:46 +0200 [thread overview]
Message-ID: <336e5dd6-038e-fad4-0038-bd2d19f0dd4a@web.de> (raw)
In-Reply-To: <1554692313-28882-3-git-send-email-wen.yang99@zte.com.cn>
> v2->v1: turn the return into a goto done.
* The version identification can be shorter, can't it?
* The expection handling should be completed for the implementation
of the function “rcar_du_of_lvds_patch” in a different way.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/rcar-du/rcar_du_of.c?id=ac5b84a1ffe93c9fb882c0f2bdfac1c33077b920#n195
How do you think about to add a few jump targets (at the end)?
Regards,
Markus
next prev parent reply other threads:[~2019-04-08 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 2:58 [PATCH v2] drm/meson: fix possible object reference leak Wen Yang
2019-04-08 2:58 ` [PATCH v2] drm/omap: " Wen Yang
2019-04-08 8:49 ` Mukesh Ojha
2019-04-08 2:58 ` [PATCH v2] drm: rcar-du: " Wen Yang
2019-04-08 8:45 ` Mukesh Ojha
2019-04-08 16:38 ` Markus Elfring [this message]
2019-04-08 9:13 ` [PATCH v2] drm/meson: " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336e5dd6-038e-fad4-0038-bd2d19f0dd4a@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).