From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F76C433DB for ; Tue, 26 Jan 2021 18:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81110207A9 for ; Tue, 26 Jan 2021 18:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391263AbhAZRWS (ORCPT ); Tue, 26 Jan 2021 12:22:18 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:11591 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731907AbhAZGyF (ORCPT ); Tue, 26 Jan 2021 01:54:05 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DPy866p8FzMPVl; Tue, 26 Jan 2021 14:51:50 +0800 (CST) Received: from [10.174.179.117] (10.174.179.117) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Tue, 26 Jan 2021 14:53:18 +0800 Subject: Re: [PATCH] mm/hugetlb: Simplify the calculation of variables To: Jiapeng Zhong CC: , , , Mike Kravetz References: <1611643468-52233-1-git-send-email-abaci-bugfix@linux.alibaba.com> From: Miaohe Lin Message-ID: <3378e469-be94-956a-a53c-4067e437e604@huawei.com> Date: Tue, 26 Jan 2021 14:53:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1611643468-52233-1-git-send-email-abaci-bugfix@linux.alibaba.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.117] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi: On 2021/1/26 14:44, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to > !A || B. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong > --- > mm/hugetlb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index cbf32d2..5e6a6e7 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h) > mpol_allowed = policy_nodemask_current(gfp_mask); > > for_each_node_mask(node, cpuset_current_mems_allowed) { > - if (!mpol_allowed || > - (mpol_allowed && node_isset(node, *mpol_allowed))) > + if (!mpol_allowed || node_isset(node, *mpol_allowed)) > nr += array[node]; > } > > I'm gonna do this too. :) Reviewed-by: Miaohe Lin