From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Juergen Gross <jgross@suse.com>,
Dan Streetman <ddstreet@ieee.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Dan Streetman <dan.streetman@canonical.com>,
Bjorn Helgaas <bhelgaas@google.com>,
xen-devel@lists.xenproject.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data
Date: Wed, 22 Feb 2017 10:14:53 -0500 [thread overview]
Message-ID: <3379a82f-04b7-152a-1577-bf99b1c638cc@oracle.com> (raw)
In-Reply-To: <20170222142810.GA28359@bhelgaas-glaptop.roam.corp.google.com>
On 02/22/2017 09:28 AM, Bjorn Helgaas wrote:
> On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote:
>> On 02/21/2017 10:45 AM, Juergen Gross wrote:
>>> On 21/02/17 16:31, Dan Streetman wrote:
>>>> On Fri, Jan 13, 2017 at 5:30 PM, Konrad Rzeszutek Wilk
>>>> <konrad.wilk@oracle.com> wrote:
>>>>> On Fri, Jan 13, 2017 at 03:07:51PM -0500, Dan Streetman wrote:
>>>>>> Revert the main part of commit:
>>>>>> af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests")
>>>>>>
>>>>>> That commit introduced reading the pci device's msi message data to see
>>>>>> if a pirq was previously configured for the device's msi/msix, and re-use
>>>>>> that pirq. At the time, that was the correct behavior. However, a
>>>>>> later change to Qemu caused it to call into the Xen hypervisor to unmap
>>>>>> all pirqs for a pci device, when the pci device disables its MSI/MSIX
>>>>>> vectors; specifically the Qemu commit:
>>>>>> c976437c7dba9c7444fb41df45468968aaa326ad
>>>>>> ("qemu-xen: free all the pirqs for msi/msix when driver unload")
>>>>>>
>>>>>> Once Qemu added this pirq unmapping, it was no longer correct for the
>>>>>> kernel to re-use the pirq number cached in the pci device msi message
>>>>>> data. All Qemu releases since 2.1.0 contain the patch that unmaps the
>>>>>> pirqs when the pci device disables its MSI/MSIX vectors.
>>>>>>
>>>>>> This bug is causing failures to initialize multiple NVMe controllers
>>>>>> under Xen, because the NVMe driver sets up a single MSIX vector for
>>>>>> each controller (concurrently), and then after using that to talk to
>>>>>> the controller for some configuration data, it disables the single MSIX
>>>>>> vector and re-configures all the MSIX vectors it needs. So the MSIX
>>>>>> setup code tries to re-use the cached pirq from the first vector
>>>>>> for each controller, but the hypervisor has already given away that
>>>>>> pirq to another controller, and its initialization fails.
>>>>>>
>>>>>> This is discussed in more detail at:
>>>>>> https://lists.xen.org/archives/html/xen-devel/2017-01/msg00447.html
>>>>>>
>>>>>> Fixes: af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests")
>>>>>> Signed-off-by: Dan Streetman <dan.streetman@canonical.com>
>>>>> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>> This doesn't seem to be applied yet, is it still waiting on another
>>>> ack? Or maybe I'm looking at the wrong git tree...
>>> Am I wrong or shouldn't this go through the PCI tree? Konrad?
>> Konrad is away this week but since pull request for Xen tree just went
>> out we should probably wait until rc1 anyway (unless something big comes
>> up before that).
> I assume this should go via the Xen or x86 tree, since that's how most
> arch/x86/pci/xen.c patches have been handled, including af42b8d12f8a.
> If you think otherwise, let me know.
OK, I applied it to Xen tree's for-linus-4.11.
-boris
next prev parent reply other threads:[~2017-02-22 15:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 19:28 [PATCH] xen: do not re-use pirq number cached in pci device msi msg data Dan Streetman
2017-01-07 1:06 ` Konrad Rzeszutek Wilk
2017-01-09 14:59 ` Boris Ostrovsky
2017-01-09 15:42 ` [Xen-devel] " Dan Streetman
2017-01-09 15:59 ` Konrad Rzeszutek Wilk
2017-01-09 19:30 ` Stefano Stabellini
2017-01-10 15:57 ` Dan Streetman
2017-01-10 18:41 ` Dan Streetman
2017-01-10 19:03 ` Stefano Stabellini
2017-01-10 21:32 ` Dan Streetman
2017-01-10 23:28 ` Boris Ostrovsky
2017-01-11 1:25 ` Stefano Stabellini
2017-01-11 15:26 ` Dan Streetman
2017-01-11 18:46 ` Stefano Stabellini
2017-01-11 23:25 ` Dan Streetman
2017-01-13 18:31 ` Dan Streetman
2017-01-13 18:44 ` Stefano Stabellini
2017-01-13 20:00 ` Boris Ostrovsky
2017-01-13 20:07 ` Dan Streetman
2017-01-13 20:54 ` Stefano Stabellini
2017-01-13 21:49 ` Boris Ostrovsky
2017-01-13 22:30 ` Konrad Rzeszutek Wilk
2017-02-21 15:31 ` Dan Streetman
2017-02-21 15:45 ` Juergen Gross
2017-02-21 15:58 ` Boris Ostrovsky
2017-02-22 14:28 ` Bjorn Helgaas
2017-02-22 15:14 ` Boris Ostrovsky [this message]
2017-05-03 18:19 ` [Xen-devel] " David Woodhouse
2017-05-03 18:43 ` Boris Ostrovsky
2017-05-03 22:59 ` Stefano Stabellini
2017-05-03 23:06 ` Greg KH
2017-05-03 23:12 ` Stefano Stabellini
2017-05-03 23:19 ` Greg KH
2017-01-13 20:13 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3379a82f-04b7-152a-1577-bf99b1c638cc@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bhelgaas@google.com \
--cc=dan.streetman@canonical.com \
--cc=ddstreet@ieee.org \
--cc=helgaas@kernel.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).