From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933314AbcKHLpa convert rfc822-to-8bit (ORCPT ); Tue, 8 Nov 2016 06:45:30 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:57344 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932775AbcKHLoB (ORCPT ); Tue, 8 Nov 2016 06:44:01 -0500 From: Arnd Bergmann To: Christophe JAILLET Cc: linux-arm-kernel@lists.infradead.org, baohua@kernel.org, gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com Subject: Re: [PATCH] serial: sirf: Simplify a test Date: Tue, 08 Nov 2016 12:41:26 +0100 Message-ID: <3381493.Qsc4sUWVSY@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <39a1050e-fb64-a6e5-8939-4e01631e59ea@wanadoo.fr> References: <20161101070333.12255-1-christophe.jaillet@wanadoo.fr> <2916662.De1FDumaQl@wuerfel> <39a1050e-fb64-a6e5-8939-4e01631e59ea@wanadoo.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:B9l+FUfbjLmyRPjR7LTpWXoPphzuKHI4QOrX2f2+KOIgUKOzUm9 BBXivUncyoN1WyWlsH03CtjiJgJDJxlh+kd4c0qqKGIX8G0KBfwnlhtLwUApNwqWrIk4Jm0 1stp/zuiar1JmN5AoPdtI0PCPevqMd/ad5M7PfhMDNFxEALfhdphGikM9tI4ZR9/yQs5/Wu 4tFZFx+Qi+mweeSGEpdDA== X-UI-Out-Filterresults: notjunk:1;V01:K0:wuaave+ggCU=:YwICO1gsp6xSFOH2owV+H+ XXX1AXQKWqcmXb/w3ngyH7DflNZuk2ZVOnFYsMsp90E8EhfOdzqHVQYvnmT6m6T7k1UnJKOXL 2oFg9KPgmBlO57HPMIzF1VsB5XbV3fADRwLfQjfF1WC9wcGcPc7PzUzfLt9xae3yzueVZutxE oVazwDd9RrDwaiKPWszmzHCzNgEIaBaeRUbqOCRJ5C1bmIDZff4PF8gVp2wGd7D1Xxqebs6cr 1KxvqrIzWxAv5R9dPAiLoUtCHinr/jOH7Na+3mO+TzajY3zIcQTUaM9O9wbWGU+xnws5HRxI1 s2uzKc9qzHdAKggLze+NMRC1uDzbHRBXb0OB1OKqyp8gMexsq+nZubdu+p6CPfA1v+5zHRzU8 WZQ5Vhy3N/JIraUaVM/f4F9bW4/GkIZcFkIC9RdANhoID4fA84ev1ADdqXOn0zTBLvnGZYCzh yVvjDBp71ybxpIe4xyCiLMju48apN3Doe6P/kO/1VeUXxVkNNJW8rli5cab9mhI+GD+Y75lPS z/IIC/A7bo6NdR2zlte4gSa0kFZA3ttdcu1ymrsYKUtbVN5R3LT7AM+Dc2x4T3oQetMAYrYpb rLa+bMatGJIV51tgM8bkHWKk3kVXrVCPKGNSb9r3+Brh/6Fuby0isNoR1+bsLK5LD2/PQY5sC ADNAUCs6mNd/EN1wE3+IEijgmeVO9x0tHJbQVrZO6GUjTp22OLjRzym5cnxAzyJh46C+HJStx Dhr11hzWif1x7hek Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, November 8, 2016 8:18:04 AM CET Christophe JAILLET wrote: > Le 07/11/2016 à 14:50, Arnd Bergmann a écrit : > > On Tuesday, November 1, 2016 8:03:33 AM CET Christophe JAILLET wrote: > >> 'dmaengine_prep_dma_cyclic()' does not return an error pointer, so the test > >> can be simplified to be more consistent. > >> > >> Signed-off-by: Christophe JAILLET > > The change looks correct in principle. It would be good to automate looking > > for other instances of this bug. How did you find it? Do you have e.g. a > > coccinelle script or did you just stumble over the issue by accident? > Hi, > > You can have an idea of the strategy used in this post: > https://lkml.org/lkml/2016/11/1/388 > > Julia is currently working on a more complete strategy in order to find > such issues. Ah, very nice! Arnd