linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Chen Wandun <chenwandun@huawei.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, guillaume.tucker@collabora.com
Cc: regressions@lists.linux.dev, Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH] Revert "mm/page_isolation: unset migratetype directly for non Buddy page"
Date: Sun, 30 Jan 2022 10:24:43 +0100	[thread overview]
Message-ID: <338bde65-5e1c-4e23-b4f2-671819c637cc@leemhuis.info> (raw)
In-Reply-To: <c0b74f54-c39a-51f7-08f8-701e9af94e56@huawei.com>

Hi, this is your Linux kernel regression tracker speaking.

On 26.01.22 03:18, Chen Wandun wrote:
> 在 2022/1/26 0:40, Vlastimil Babka 写道:
>> On 1/17/22 15:27, Chen Wandun wrote:
>>> This reverts commit 075782149abff45ee22f27315eced44d02b96779.
>>>
>>> commit 075782149abf ("mm/page_isolation: unset migratetype directly for
>> That's an old -next commit id, it went to mainline as 721fb891ad0b
>> ("mm/page_isolation: unset migratetype directly for non Buddy page")
>>
>>> non Buddy page") will result memory that should in buddy disappear by
>>> mistake. move_freepages_block move all pages in pageblock instead of
>>> pages indicated by input parameter, so if input pages is not in buddy
>>> but other pages in pageblock is in buddy, it will result in page out of
>>> control.
>>>
>>> Reported-by: "kernelci.org bot" <bot@kernelci.org>
>>> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
>> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>>
>> #regzbot ^introduced: 721fb891ad0b

Thx for getting regzbot involved, much appreciated.

>> There should better be also:
>>
>> Fixes: 721fb891ad0b ("mm/page_isolation: unset migratetype directly
>> for non
>> Buddy page")
>>
>> Especially as that commit had a (inadequate, IMHO, for an optimization)
>> Fixes: tag and could end up being backported somewhere without the
>> followup
>> fix/revert.
>
> thanks, I will send v2

Just wondering:

Andrew, I don't see this patch in the list of changes you sent to Linus
yesterday. Shouldn't it be in there due to above reason alone? And there
is another reason: it seems to be an issue people actually hit, as
Guenter mentioned in this thread. It thus complicates things for those
that want to help testing pre-releases.

Or am I missing something/asking too much in this case?

BTW, let's tell regzbot about v2:

#regzbot monitor:
https://lore.kernel.org/all/20220126024436.13921-1-chenwandun@huawei.com/

Ciao, Thorsten

>>> ---
>>>   mm/page_isolation.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
>>> index 6a0ddda6b3c5..f67c4c70f17f 100644
>>> --- a/mm/page_isolation.c
>>> +++ b/mm/page_isolation.c
>>> @@ -115,7 +115,7 @@ static void unset_migratetype_isolate(struct page
>>> *page, unsigned migratetype)
>>>        * onlining - just onlined memory won't immediately be
>>> considered for
>>>        * allocation.
>>>        */
>>> -    if (!isolated_page && PageBuddy(page)) {
>>> +    if (!isolated_page) {
>>>           nr_pages = move_freepages_block(zone, page, migratetype,
>>> NULL);
>>>           __mod_zone_freepage_state(zone, nr_pages, migratetype);
>>>       }
>> .
> 
> 
> 


  reply	other threads:[~2022-01-30  9:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 14:27 Chen Wandun
2022-01-17 15:32 ` David Hildenbrand
2022-01-26  2:17   ` Chen Wandun
2022-01-18 13:50 ` Dong Aisheng
2022-01-24  8:41   ` Francesco Dolcini
2022-01-25 16:40 ` Vlastimil Babka
2022-01-26  2:18   ` Chen Wandun
2022-01-30  9:24     ` Thorsten Leemhuis [this message]
2022-01-31 22:39       ` Andrew Morton
2022-01-26 21:11 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=338bde65-5e1c-4e23-b4f2-671819c637cc@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=akpm@linux-foundation.org \
    --cc=chenwandun@huawei.com \
    --cc=guillaume.tucker@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=regressions@lists.linux.dev \
    --cc=vbabka@suse.cz \
    --subject='Re: [PATCH] Revert "mm/page_isolation: unset migratetype directly for non Buddy page"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).