From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756765AbcKKNr2 (ORCPT ); Fri, 11 Nov 2016 08:47:28 -0500 Received: from mail-sn1nam02on0088.outbound.protection.outlook.com ([104.47.36.88]:61576 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756436AbcKKNrZ (ORCPT ); Fri, 11 Nov 2016 08:47:25 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/radeon: use list_move in radeon_vm_bo_update To: Geliang Tang , Alex Deucher , David Airlie References: CC: , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <3391741d-219d-d778-9d34-e050d8ea1f17@amd.com> Date: Fri, 11 Nov 2016 14:46:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:5432:9c74:a914:dd49] X-ClientProxiedBy: HE1PR01CA0079.eurprd01.prod.exchangelabs.com (10.165.170.175) To DM5PR12MB1307.namprd12.prod.outlook.com (10.168.237.150) X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;2:Zc9GnTxJkNuiSAfcbbxBu9/VzBcvEo5dUjr16GWqPEFlZvVerO3DlhQzTe6TzSL5ydHwRRfTFNz8SUEddal8EIsj1CJUnUPr23sXwvaJdOMAnmtSeWm7rdpiPonIfqYuRoYyowozauBFJb8qJlHbb1JtfZudhXCi9/EasDeMEZ8=;3:nPSltqXi3AKGFQbL6D2fL+Ir5g6Z0id4hNozUnTnpAW3Ud2E9pdCe1QUNOLwPUL4QHaHHqfLfzUCTMB38IE9O5U6VD2bqg/e2nwqxYgwP5YuFRtTcvNWM9SkwdGTvV2XoByITaR+E+wImTdr6W+Ek0sJrd3yypMbP8kYmtaQCWk= X-MS-Office365-Filtering-Correlation-Id: 939ae09d-5323-4841-a712-08d40a393a6d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR12MB1307; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;25:mmEGj/DMRaijNl+jkkyhkSNzF1zgYH3aFtu6fmZNwP+ezcKalCbUg+26P2PBBcB7ertBxYzj/e7mXEq4Gpz8WNKef6w3XP1xyVH5pMYV/uUFyOIOehQpKMXb2r4MwtE+AphYCzX9jntmtXnIG3ZnHlJiBJtD2KDMYA7mYoWWyGgZVoVQxIXAxlWO/LlfaNp0ARFZUckS5H8mVgjAAhMnAfhgWmj2Tev9X/+gj8HR4XP3rDtQlO1kpboQpGd1EdRIexNIuHF+tMOI69Pqfyb/ftsrDSRhOdRyXwmzWuNd9U1FUDm+YKpp9UbfbbwVqSy1fAqdYafXe44D3QuGTStYDmrk4K9ZZGf0c6ZvYzwF45eF8Ijtw/q2T4lX5ND29EQs4HWIzv8Plv8G4pl2MaFvaKOV7fzJov+Ddr5Fz2nvfbriQQAu7AzRXFuXHuT5JAJvXg57jJNF0ZUtKd8F1urGcTvDwAX6nRTXKsKkK5gx6hqmAfVpXszUM4Ffg1ylBgVKZkCFRv9m9O59mzeyeV2YhgSV8K74MjbOoFHcKqQEa3ZyQmvMHVHfUb7t6A+i0zk4fcIDkDbGuIZ/lxJYzzUeU9+T/OXsorYE1evmW+V7bSgMp0Uy6jRO1vupJMco+JrbigTPPkWmo0QIRsrBb1NM3Gv+oR+3ur+vqJjHWl77tmfqv/DNt108RlZh9Bybx0sHouLNI1NAQ5XnlG0i09oU8bEuyvQAfzcfLSQrdCB4f2xdluGICtDUlpvfBe/mY63l X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;31:2Tjkfdc+koVTHvH0ZTwhT2SfC8peX0g6/TV2SVIlalkzsqGJNEVpK4sPyKkQwEMluF/EMtnlZHA9rCPcYcFr3m720SkzCcbQZ0tRj6OsXOwvYwB4aKD0WZIhI578sPIaXVKrufl19xlAdTQwWVQVRnWtN12SgwaSD+Uil+q3Bb5mKB0ZfjoFvwkEW84OYvPRbq0w1SVBz6JnduRKZyaemUMU7LMMJ0W/KKR219iV0c77aA73ti0/flhPIHCqsAGyhAyQ96JTFKedc+T9sqk1Gg==;20:r14T2uyGqT9mfNLwEtfLMjLSnoH4MvABUNLc4Qq2/9632zsRrp9j5QRxtPgR1LnZxOfkNuXvH+0w2jDWcCxbdtlfCpWCPA0CHCupQ6/JHdZmicwbDmZZ7y6bpy68X5U/ToCyWqqCP3y+G5/l2FKSN/Ayq7GOVrtA4dSF3jWMRfBpLKn4bgCsIgsA/L64jwJLtVIauxewvr58Bcrpt96tkTsx1ZEL9hPe3YVDihPEDIw6cIG8LGYXv0t60bGbJIbdWWA++JZDOQgBvaS8HFNwRjPcI2nj20h5w2F68goJ2AQh0Ef22YqNQq8Am0PPXzkeHjoh3N1bJvQ+DjH0vpQDDT8hY4tzoYLn+y4vCs1zdmdwX6ZL/ivTzqfSvXMfTwNqY+bEmFYW8Q48gonH9//gaiHUjoLMFHKA55jmBIr+zPzaIPgTDe+s4VwYyl/bXKpGb0YL4k8C0y+ANcNprzQ511wgjr7yu+F/HoS2pNA5tYZYgWSPix5noOXA5PU0f3po X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DM5PR12MB1307;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1307; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;4:Q1tkHTk9yq48cHtqo3i+RAMJoDzvQfAWO8MfA9RJpVQUKsD9CV+tfXrKaTSsbH1qNMFEoZd7iOhFUAcFqm9emQiDoeuZQU8P8lAeVQCyWB3d1Xnoc8rDJe6lYJscmnhIv5kvAf84HyhgNGutg/itssgMWRjUqV3C77lpLylzPHwZoybPXvauuR50FKZ6pjV2Vrv/cIxaCDA8F4VBSWhPaijxJiODH0G7LOKg7zeyFBdw6RJ/xXzPOOCv9u/j+QiY9udWMOYKO5AT9lq/XQ8HOtqmhZ+PeJ5tNT69yMjM6jtS4+X2ybOHN+x/o4HYAGhclYqDtT/iFyJzBX+bgce4G8OjpOjqpKaeLAMRCfYQ2poH6BJGDtYgsvlt1d29F8zmwkh9HqSqppdLZrVfuxOnQLN7k/u/j57CZpJHTwpxIV1YBhYLIz6Kv0kN4nDD3TH5Y97i2cR7HqRtQPkfTarYlQ== X-Forefront-PRVS: 012349AD1C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(5660300001)(65826007)(77096005)(1706002)(2950100002)(4326007)(42186005)(65806001)(189998001)(105586002)(6666003)(47776003)(65956001)(586003)(31686004)(86362001)(2906002)(31696002)(4001350100001)(68736007)(5001770100001)(97736004)(54356999)(36756003)(76176999)(50466002)(50986999)(92566002)(7846002)(101416001)(6116002)(81166006)(81156014)(83506001)(33646002)(23756003)(7736002)(2870700001)(305945005)(229853002)(8676002)(106356001)(64126003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1307;H:[IPv6:2a02:908:1251:7981:5432:9c74:a914:dd49];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;DM5PR12MB1307;23:gecQwUfpKzxKBbJySKNFKyrxvPal4HLtz6wny/?= =?iso-8859-15?Q?y9YuEPk/g0mbFshpTukeNATKvfWJkRZjrRRBeljoNZq2lJNvVHUApgxjn?= =?iso-8859-15?Q?RaFIL9+xWBEXSqSXqLi1iUCKI/H8UT8KXa/nwILUxdGCyByBATwAHPfMI?= =?iso-8859-15?Q?5RlQCdhRSA5p+mTsppec5aqAZHgI0ehD2fi57RlFeMBHQZHAfrqYKwyp1?= =?iso-8859-15?Q?plxsGkwHPLVI5MGqf/v0VdjZBzgW57KbjZRwrIyc5cY+ELn/4OLDEnUQO?= =?iso-8859-15?Q?dmuSO6xiU1F+8xvWTUVGY1fBnAB9w+qoPewk5IUHGID7qSy944FHrHzMH?= =?iso-8859-15?Q?LqudimmQ0sS5qj0dhJ+35Oij1vEUqUGyFlexEbQe4MOE+105Pg87eexr0?= =?iso-8859-15?Q?Maro2trSAFZXSSz9b/+Htio0RjKA2rRVPVipTkMU4oXn4IvsPod2wkkEq?= =?iso-8859-15?Q?rU7UuBEoPXt5wRbOtuHF1OYLfhbmp+AsL681PjanfHJABZBqxbb2wbCvG?= =?iso-8859-15?Q?1FcEpnAsLJJUAzYZl5O8D004K0T8CW1g0NnmjyI0AkGyy+gl/kOgq2e6W?= =?iso-8859-15?Q?UMolNdy0t60+R3Sv0UDcpC3Go25tyEa6elG55Qk8QSb6q3Fq5+w3Y1EJh?= =?iso-8859-15?Q?8Uwp6gF2+7Bm/3hwktNZf69srEwg+Wnd7tpIoipirkoSO2t5A1ZuetTpR?= =?iso-8859-15?Q?QT5qaoDtvRXuyJSxYN+NUVa04Lcdt1KNt2saOXHE/vbDQatsSzuzUPMNO?= =?iso-8859-15?Q?EPah96qYcrejgsnevHC6gLYtTJuEMiZXbJDLJzntn04yj/YISLgksUyOE?= =?iso-8859-15?Q?C+e2QgGuQHb33ghOCNpD/7S7zPfGr6fv9LstQePAoOuQlBpnjCp5nPYso?= =?iso-8859-15?Q?pyaSC2g0cwj5EHEj24jL/TEffNXhWxBVIvGJCJauHLCPPnzYMp9uFOStG?= =?iso-8859-15?Q?WzTrE13Bd6HrpwiXHDXJ5NsR4RcQUMuGV9Vje87WE00hAmdptGtirfJnG?= =?iso-8859-15?Q?vdQ2WrmR88BqRoFf5j46wyTHM/VXRw4cLaEOUzP8+r5h/Dyn1ETijsRyN?= =?iso-8859-15?Q?AP49TcmSJXdPuLmdw1e52ysgEJKNnsAndbxvSxz4YesrFz2LmxgbfgZqP?= =?iso-8859-15?Q?hWFyUY75uhQX+ZxJwNFuxDnf7nOTooU4ZCoDGS5qkIwywycQcEnXzFNVq?= =?iso-8859-15?Q?/LagRq3mdcrSCa6K1vBSm8qBCfjsYD0fTBSFl2s1/SlNBujG1Wv6akOFo?= =?iso-8859-15?Q?2WCTfK/+Wclr0UyslHOMg5yYLbmSm41d36kPw6?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;6:skiCT2dxTodXmUFzURu+eB9iRqH+b2OE4Ep7ZgfYeX6lUDJ7zOszMH227Z06c++VDKcfywezZzKFDWHcFbkpiTxe/MEreYR/McvDsliLXCtaBAIZCdyaxxkCK+s5SC7LS0OQKm+oot9ME4fLeCV/lDyFJ8BBCPpYh5joijg0hme+CO4e3tl+w127jn7NmjZYW1TeSFm/XmnKEFxGBVyzT05UOPHdDCH+GMfI71jbniatojwfK1fN7pJHD63gnqaPT7bAQMkOSMtLWUmiVL0ee1+EPwqkxieWboQWQY6asohr1LQFHQ/GIg/Gg0GiPhNQl4UxsAtqgAKFNgIlqtK2lMdTsSxvEXq0kB+9xTYRkKs=;5:nSSC7ma5NQcPHuG6B52RHxpw9MyQP8AclJ/X5EUxx2ASo2KBX+I1KlES5iztYIMaDLM1X9ganQbaqRUcto1tq/KZjIIahtmiIOMRvbv6bv8I4nGSgoIrKzWF/I/yBevDoKkCWbGMYCg2kn2C0oipQg==;24:7bdhxr29eUu/2353VbQr67uNwT/zG7XviMYaQHFxkSl3J+Knq+9W0mFD8SQLIXaA0ZvhjuWPf5Bbzxo2HnBjX+Y9FcZsZ342daTWvswnptU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;7:1j8Lj+Ridx8yDIfO654Im82it4DMmbwrBwV1WTSOuiTCK4D01Jihss/Bvv1a+bx5gcFhztxShZTfIT+QgBtVJSd0zGyrOpvCGZbec6EZ+JW10e08yHG72HynV+dwAAv92JdydtOnnmeYoXszbJIosMmNGhbjg0i8inH2lcrZjTfRX0t8uMDaaGb0wYHEewl8mDVaIzKEqE3NSaIyqEzv1sQLwfo08vP+f6FGXIJaEm2OmXBsjH5ydRDEfTiczF99N9sLi6HGK7xvO4WQ7uwN8e5mCDTvtWZq/1F7rd8tmn5QrNL8UowDCAVBqHeFoo4qZISezV3Wsvm8pVZA2ZNy9mLiT35AlqkTczwb8/csEvc=;20:rRfdMJXUM+Qvcjo7B39NHuXqYFqs2hzG/YnN1CufTpagRyhyY4Ax5XKcm5zef3icUVZ5FxUpjjnb5dWx0I/S8t/zTYY9iddEVIPKOYb0Tth+diALF3W4q6pXAatLJ5jQJIS5GX617Ai8C0dXuGHW0DiyvMJomxhG6foSvS2683ermRjIumOwser36OMQv3uUmvMS0jWdvICgYZeX9jse7zBnIOSURutaH811iPdtzzG+dcxaZ7YR9rbZqvv1jU59 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2016 13:47:06.2509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1307 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 11.11.2016 um 13:26 schrieb Geliang Tang: > Use list_move() instead of list_del() + list_add() to simplify the code. > > Signed-off-by: Geliang Tang Reviewed-by: Christian König . > --- > drivers/gpu/drm/radeon/radeon_vm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c > index a135874..2f1e372 100644 > --- a/drivers/gpu/drm/radeon/radeon_vm.c > +++ b/drivers/gpu/drm/radeon/radeon_vm.c > @@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev, > } > list_del_init(&bo_va->vm_status); > } else { > - list_del(&bo_va->vm_status); > - list_add(&bo_va->vm_status, &vm->cleared); > + list_move(&bo_va->vm_status, &vm->cleared); > } > spin_unlock(&vm->status_lock); >