Re: [PATCH 10/11] acpi: bus: Set _OSC for diverse core support

From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
	peterz@infradead.org, x86@kernel.org, bp@suse.de,
	sudeep.holla@arm.com, ak@linux.intel.com,
	linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
	alexey.klimov@arm.com, viresh.kumar@linaro.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	lenb@kernel.org, tim.c.chen@linux.intel.com,
	paul.gortmaker@windriver.com, jpoimboe@redhat.com,
	mcgrof@kernel.org, jgross@suse.com, robert.moore@intel.com,
	dvyukov@google.com, jeyu@redhat.com
Subject: Re: [PATCH 10/11] acpi: bus: Set _OSC for diverse core support
Date: Sat, 20 Aug 2016 02:51:14 +0200	[thread overview]
Message-ID: <3394418.ZE72EMLDjL@vostro.rjw.lan> (raw)
In-Reply-To: <1471559812-19967-11-git-send-email-srinivas.pandruvada@linux.intel.com>

On Thursday, August 18, 2016 03:36:51 PM Srinivas Pandruvada wrote:
> Set the OSC_SB_CPC_DIVERSE_HIGH_SUPPORT (bit 12) to enable diverse
> core support.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  drivers/acpi/bus.c   | 4 +++-
>  include/linux/acpi.h | 1 +
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 61643a5..fbd3b7c 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -336,7 +336,9 @@ static void acpi_bus_osc_support(void)
>  		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_CPCV2_SUPPORT;
>  	}
>  #endif
> -
> +#ifdef CONFIG_SCHED_ITMT
> +	capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_CPC_DIVERSE_HIGH_SUPPORT;
> +#endif

	if (IS_ENABLED(CONFIG_SCHED_ITMT))
		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_CPC_DIVERSE_HIGH_SUPPORT;

pretty please.

>  	if (!ghes_disable)
>  		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_APEI_SUPPORT;
>  	if (ACPI_FAILURE(acpi_get_handle(NULL, "\\_SB", &handle)))
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 4d8452c..17f6e08 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -460,6 +460,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context);
>  #define OSC_SB_CPCV2_SUPPORT			0x00000040
>  #define OSC_SB_PCLPI_SUPPORT			0x00000080
>  #define OSC_SB_OSLPI_SUPPORT			0x00000100
> +#define OSC_SB_CPC_DIVERSE_HIGH_SUPPORT		0x00001000
>  
>  extern bool osc_sb_apei_support_acked;
>  extern bool osc_pc_lpi_support_confirmed;
> 

Thanks,
Rafael