From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756209AbcBPWJD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 17:09:03 -0500
Received: from mout.kundenserver.de ([212.227.126.133]:56777 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756022AbcBPWJA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 17:09:00 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
        Mark Brown <broonie@kernel.org>, Han Lu <han.lu@intel.com>,
        Libin Yang <libin.yang@linux.intel.com>,
        Thierry Reding <treding@nvidia.com>,
        David Henningsson <david.henningsson@canonical.com>
Subject: Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer
Date: Tue, 16 Feb 2016 23:08:13 +0100
Message-ID: <3395859.dhsfOsmVIe@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <2706488.VpKveMVPGI@wuerfel>
References: <1455634059-1896914-1-git-send-email-arnd@arndb.de> <s5hr3gc60ph.wl-tiwai@suse.de> <2706488.VpKveMVPGI@wuerfel>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:BgDWvjVYBI1qmgJHbsj9SJQJV9wBQhOOCekfzNjc/2MZ34Cuojv
 0Jr8zTdPN2W/x8CxfY5cA2UPn/TGF0qZombFgYSbkxwyraolm7UineM4/qZ3HABU0XSsCVt
 jYr+I9f0lBrQCbh4hulv/dRq4D1AbfRtetKasuJ+iVViFzrh1R5IGWZq+VsQ1gh4cU1L8A8
 +jU3/S73uaJuMzWAxVNhQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:NXUEa1sNzaY=:LEHygUnovL2vQbVJe3Xop7
 Lz3Km6xuVuFPbtqmtBHzcOE26lU9vK/Uj0inslAjDlduXTnTRv36GdiYm5uMqk5JE/juuybUO
 8RLZI3NCPLFg8D3d387R5DphtHHAuJy61cjb/oFsIYf4rPzTli9a+t3/vi136clUlkVXVqWHW
 R0atIK/4VNMjC9lN/dCjgYC62KvC7TWAbdai5fBP+KbR66EuBqMFApwaoxs7mDsyqf+5b0f6B
 AwJjUeHGmmO9VZakULPVgSMqyJLiz9CrSEZcSATJEMWR6et+4EuMCytDLv+4u1rhWP/iml1p1
 LC4bSyoDlqRL0+9JTmEhazoWmmHaVIKsj7+Gwoh/fFDq9NDuIgrk6LVT2ZfjpxH2X3M8Rn3cc
 r3KaEtP9ACYI+6THwbgmXIXE/lAtniQoqwokse2bwR+QZamCXAad8IVv/9qmhnoUJJCXDue+J
 O3xIsyfhpjsn9MXUo+M6H+o1CmunHxgLLMK3L18Vxwtf++lyM9nsD08tkdvjkDru96eS2AguU
 qVlfyWTv7wTKZooSoF8lTQZWUWsBrraqq9htH0u+a4G8TWyp6DBTOVL7KD66upyqMIjnCPZEB
 FJbiZNDCvqCGdmzyV7j6dsr5F9tFnNwEvl4mPC/hoxKj8IpidpSgBXXbvaSzl968O6zQkjzL7
 59UbBlyoxQW7BdCBFDRMc8obC2vjKHNU+zATmORTD1dZvkZkIC9zJugF31/+Qb+Hk3Ga12ZKh
 gKSsO161y0yB2/p0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 16 February 2016 18:26:09 Arnd Bergmann wrote:
> >                 return err;
> >         per_pin->acomp_jack = jack;
> > -       jack->private_data = per_pin;
> > -       jack->private_free = free_acomp_jack_priv;
> > +       if (jack) {
> > +               jack->private_data = per_pin;
> > +               jack->private_free = free_acomp_jack_priv;
> > +       }
> >         return 0;
> >  }
> > 
> Looks good to me.
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 

Actually, on second thought, there is one notable downside
of this approach: 'jack' is guaranteed to be NULL here, so gcc
won't produce a warning if another driver makes the same mistake:

By default, we only get a warning for uses of uninitialized
variables, but not those that are known to be NULL. I think
some compiler warnings are able to warn about that too, but I
forgot the details.

	Arnd