From: Heiko Stuebner <heiko@sntech.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Sandy Huang <hjc@rock-chips.com>,
kernel-janitors@vger.kernel.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put
Date: Sun, 13 Jan 2019 19:48:49 +0100 [thread overview]
Message-ID: <3397932.PmTvevuZIG@phil> (raw)
In-Reply-To: <1547369264-24831-4-git-send-email-Julia.Lawall@lip6.fr>
Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
>
> for_each_child_of_node(root, child) {
> ... when != of_node_put(child)
> when != e = child
> + of_node_put(child);
> ? break;
> ...
> }
> ... when != child
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
I've added a fixes+stable tag and applied it to drm-misc-fixes
Thanks for catching that
Heiko
next prev parent reply other threads:[~2019-01-13 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 8:47 [PATCH 0/4] add missing of_node_puts Julia Lawall
2019-01-13 8:47 ` [PATCH 1/4] drm/mediatek: " Julia Lawall
2019-01-13 8:47 ` [PATCH 2/4] drm/imx: imx-ldb: " Julia Lawall
2019-01-17 14:00 ` Philipp Zabel
2019-01-13 8:47 ` [PATCH 3/4] drm/rockchip: add missing of_node_put Julia Lawall
2019-01-13 18:48 ` Heiko Stuebner [this message]
2019-01-14 10:05 ` Daniel Vetter
2019-01-14 10:09 ` Heiko Stuebner
2019-01-13 8:47 ` [PATCH 4/4] drm/sun4i: backend: add missing of_node_puts Julia Lawall
2019-01-16 8:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3397932.PmTvevuZIG@phil \
--to=heiko@sntech.de \
--cc=Julia.Lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).