From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756535AbdIHPQL (ORCPT <rfc822;w@1wt.eu>);
        Fri, 8 Sep 2017 11:16:11 -0400
Received: from esa6.dell-outbound.iphmx.com ([68.232.149.229]:12519 "EHLO
        esa6.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1756505AbdIHPQJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 8 Sep 2017 11:16:09 -0400
From: <Mario.Limonciello@dell.com>
X-LoopCount0: from 10.175.216.250
X-IronPort-AV: E=Sophos;i="5.42,361,1500958800"; 
   d="scan'208";a="145891413"
X-DLP: DLP_GlobalPCIDSS
To: <mika.westerberg@linux.intel.com>
CC: <dvhart@infradead.org>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <hughsient@gmail.com>,
        <yehezkelshb@gmail.com>
Subject: RE: [PATCH v2] Add driver to force WMI Thunderbolt controller power
 status
Thread-Topic: [PATCH v2] Add driver to force WMI Thunderbolt controller power
 status
Thread-Index: AQHTKHmD0WqrKBCCXUmI4C/cXz/ihqKrGVKg
Date: Fri, 8 Sep 2017 15:15:10 +0000
Message-ID: <339f06ce8efd42409bf5f91dfd064e7a@ausx13mpc120.AMER.DELL.COM>
References: <1504810042-4696-1-git-send-email-mario.limonciello@dell.com>
 <20170908080729.GT2477@lahna.fi.intel.com>
In-Reply-To: <20170908080729.GT2477@lahna.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.18.86]
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v88FGGK7017135

> -----Original Message-----
> From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com]
> Sent: Friday, September 8, 2017 3:07 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; LKML <linux-kernel@vger.kernel.org>; platform-driver-
> x86@vger.kernel.org; Richard Hughes <hughsient@gmail.com>; Yehezkel Bernat
> <yehezkelshb@gmail.com>
> Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power
> status
> 
> On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Limonciello wrote:
> 
> I have a small comment which you might want to consider.
> 
> > +static int intel_wmi_thunderbolt_probe(struct wmi_device *wdev)
> > +{
> > +	return sysfs_create_group(&wdev->dev.kobj, &tbt_attribute_group);
> > +}
> > +
> > +static int intel_wmi_thunderbolt_remove(struct wmi_device *wdev)
> > +{
> > +	sysfs_remove_group(&wdev->dev.kobj, &tbt_attribute_group);
> > +	return 0;
> > +}
> 
> In order to notify userspace about this, what if you send KOBJ_CHANGE
> for the wdev when you add/remove this attribute?

Sure, makes sense to me.   I'll send a follow up patch.