From: Florian Fainelli <f.fainelli@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
bcm-kernel-feedback-list@broadcom.com,
linux-mips@vger.kernel.org, Paul Burton <paulburton@kernel.org>,
Maxime Bizon <mbizon@freebox.fr>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v2] mips: BCM63XX: ensure that CPU_SUPPORTS_32BIT_KERNEL is set
Date: Sat, 6 Nov 2021 12:34:11 -0700 [thread overview]
Message-ID: <33e97b1c-448a-ca46-724c-b10539d5e811@gmail.com> (raw)
In-Reply-To: <20211106154911.26222-1-rdunlap@infradead.org>
Le 06/11/2021 à 08:49, Randy Dunlap a écrit :
> Several header files need info on CONFIG_32BIT or CONFIG_64BIT,
> but kconfig symbol BCM63XX does not provide that info. This leads
> to many build errors, e.g.:
>
> arch/mips/include/asm/page.h:196:13: error: use of undeclared identifier 'CAC_BASE'
> return x - PAGE_OFFSET + PHYS_OFFSET;
> arch/mips/include/asm/mach-generic/spaces.h:91:23: note: expanded from macro 'PAGE_OFFSET'
> #define PAGE_OFFSET (CAC_BASE + PHYS_OFFSET)
> arch/mips/include/asm/io.h:134:28: error: use of undeclared identifier 'CAC_BASE'
> return (void *)(address + PAGE_OFFSET - PHYS_OFFSET);
> arch/mips/include/asm/mach-generic/spaces.h:91:23: note: expanded from macro 'PAGE_OFFSET'
> #define PAGE_OFFSET (CAC_BASE + PHYS_OFFSET)
>
> arch/mips/include/asm/uaccess.h:82:10: error: use of undeclared identifier '__UA_LIMIT'
> return (__UA_LIMIT & (addr | (addr + size) | __ua_size(size))) == 0;
>
>
> Selecting the SYS_HAS_CPU_BMIPS* symbols causes SYS_HAS_CPU_BMIPS to be
> set, which then selects CPU_SUPPORT_32BIT_KERNEL, which causes
> CONFIG_32BIT to be set. (a bit more indirect than v1 [RFC].)
>
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-mips@vger.kernel.org
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Maxime Bizon <mbizon@freebox.fr>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Randy!
--
Florian
next prev parent reply other threads:[~2021-11-06 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 15:49 [PATCH v2] mips: BCM63XX: ensure that CPU_SUPPORTS_32BIT_KERNEL is set Randy Dunlap
2021-11-06 19:34 ` Florian Fainelli [this message]
2021-11-09 15:29 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e97b1c-448a-ca46-724c-b10539d5e811@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mbizon@freebox.fr \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=rdunlap@infradead.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).