From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756285AbdKCNY3 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 09:24:29 -0400
Received: from mout.web.de ([212.227.15.3]:53235 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755667AbdKCNY1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 09:24:27 -0400
Subject: Re: [PATCH v2 0/3] Sony-laptop: Adjustments for
 sony_nc_setup_rfkill()
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Darren Hart <dvhart@infradead.org>,
        platform-driver-x86@vger.kernel.org
Cc: Marco Chiappero <marco@absence.it>, Matthew Garrett <mjg@redhat.com>,
        Mattia Dongili <malattia@linux.it>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Andy Shevchenko <andy@infradead.org>
References: <f33d9aa0-1a8e-f702-7513-5c0d5b464529@users.sourceforge.net>
 <CAHp75VcMkXCioCzmLE0+BTmkqc5RSOx9yPO0ectVHMrMvewgwg@mail.gmail.com>
 <17ee534c-9fe6-19c4-0522-76cd3cbe5f88@users.sourceforge.net>
 <CAHp75VfaWLSwzLpnWHj0sD9ZVVbSCi+ya_+PESXjU2FbHefE0Q@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <340e5426-a9ba-2193-2735-85e918773785@users.sourceforge.net>
Date: Fri, 3 Nov 2017 14:23:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAHp75VfaWLSwzLpnWHj0sD9ZVVbSCi+ya_+PESXjU2FbHefE0Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:Hdx4jBSV6zJR6eNrFHGP2qdt++vBvkZGsboeOYRusx9JSob8VCK
 94vuQjh4gx9cOFwWuqw2R+7C7acRNlzjpi198UQiigkSlSLmxcz8CqCY4z//PcJ3jrewvCo
 sVzCT/IvlSGwXgmDXmShtzfXwmwKe/qMWzYfVb0FofS+3n57Dc79wgWpb/7cfn2eF1PFYeE
 MjP3OJXUaGXpiG8VYk5hw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:3g+BfJvudKw=:MSx/B9pb38bxiC9pH1Z5xV
 IxrfGiqgp5wdVWGgHm7GIKVtK7KmQzkNjTzPJab2CpOF3BGoy5HfCziJDPg+1HCkBDTAh04+i
 mbxs80wBvU6aIaJ0RlaOK9+DXDyNpLw88AQxYTb+s670sqlJCvPx4yrsj4HMvfGX0xIWb0yFa
 Z77n7X1HDkZUJ7rFoBuOHNEB1oPkeymVO+A6XycLzx5FT7UzT5TObtMMq5RypbyYYFMq5bu5y
 lGRNKa6r3R5QO4W5ywibWd0Ltsn1RBwQglNR/E665MhhkGGYhlL6qhrFn5h7EHlGJZWJ+NClJ
 bMretgp0+3bq+Db7kMDLXq/nhRX8mEoF0mnEvcq87LaTetThYV7huifGyZWpVqjng9LHScaMK
 qGyVp0OdNB3tJmleosQwdsnbj5k8TPtUiierrI2wuiobf0EMQyZ1jo2t+Ic8PyDYTOwUHpkVE
 vYFgHzY0nNEuCnFZTXThyh0WEBM252LVR08sMhTtEo6k0NwnMB1xkxaSnUovqmTV+Qh7PTNST
 6s/HasnPSE6JM4rhDcRmQtvUL6w4t+TImPf8udPkdVUEKM/pRFZhI0GtS3M0SQu9L44fMu3PH
 Y/IkiG1UaeQprKoMDwkaM43jRlbGkhHlIj3sqi2P5AtpiT804JW7riNFcdXy/nfCVbB21YHn6
 pY7rR/gRdLn/oZCrWV3XKAwtpqviCGC38saCF67b1p5jTHkmrU8xNUw/KExrWlrwoZzgV/9C/
 3/2oIpL3cpIsOEeYBp8UiTFUy/WpOp4iNOzdFIhYCJ0YiagLwWolvAk5cwuRCYLfBvXXK5jeC
 3OgGfzU0psFKZF44e3eFujVj8JPOp3nfqlO1lJ8E9vgxRUcF98=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I have applied first two,

Thanks for another change acceptance.


> the last one is subject to discuss a necessity of it.

I can offer another bit of information for this software development discussion.

The following build settings were active in my “Makefile” for this Linux test case.

…
HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O0 -fomit-frame-pointer -std=gnu89
…


The affected source file can be compiled for the processor architecture “x86_64”
by a tool like “GCC 6.4.1+r251631-1.3” from the software distribution
“openSUSE Tumbleweed” with the following command example.

my_cc=/usr/bin/gcc-6 \
&& my_module=drivers/platform/x86/sony-laptop.ko \
&& git checkout ':/^Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup_rfkill' \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \
&& size "${my_module}" \
&& git checkout ':/^Sony-laptop: Use common error handling code in sony_nc_setup_rfkill' \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \
&& size "${my_module}"


Do you find the following details useful for further clarification?

text: -32
data: 0
bss:  0

Regards,
Markus