From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Simon Shields <simon@lineageos.org>, linux-leds@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] leds: add Panasonic AN30259A support
Date: Fri, 27 Jul 2018 22:22:36 +0200 [thread overview]
Message-ID: <341157fb-257d-8984-c8d3-0e4a51c4479e@gmail.com> (raw)
In-Reply-To: <ba747c6d-c8a6-438b-efcf-95e24db0a09c@gmail.com>
On 07/27/2018 10:08 PM, Jacek Anaszewski wrote:
> Hi Simon,
>
> Thank you for the updated patch. It looks good in general, with
> one reservation, please refer below.
And one more issue:
drivers/leds/leds-an30259a.c: In function 'an30259a_blink_set':
drivers/leds/leds-an30259a.c:129:23: warning: unused variable 'duty'
[-Wunused-variable]
unsigned int led_on, duty;
^
BTW, this patch set version should be v4, so please set the next
one to v5.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2018-07-27 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 14:12 [PATCH v3 0/2] Panasonic AN30259A support Simon Shields
2018-07-21 14:12 ` [PATCH v3 1/2] dt-bindings: leds: document Panasonic AN30259A bindings Simon Shields
2018-07-21 14:12 ` [PATCH v3 2/2] leds: add Panasonic AN30259A support Simon Shields
2018-07-26 7:44 ` Pavel Machek
2018-07-27 20:08 ` Jacek Anaszewski
2018-07-27 20:22 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=341157fb-257d-8984-c8d3-0e4a51c4479e@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).