From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing
Date: Fri, 10 Feb 2017 21:26:55 +0100 [thread overview]
Message-ID: <3421824.lhyKKsOD1E@wuerfel> (raw)
In-Reply-To: <CACRpkdYmfv0XCirnaMSqZ7O9cKp2XAvqJoGQBSXqHN9fSKGnHg@mail.gmail.com>
On Friday, February 10, 2017 2:12:36 PM CET Linus Walleij wrote:
>
> > + /* Right now device-tree probed devices don't get dma_mask set.
> > + * Since shared usb code relies on it, set it here for now.
> > + * Once we have dma capability bindings this can go away.
> > + */
> > +
> > + retval = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > + if (retval)
> > + goto fail_create_hcd;
>
> Were you able to test this part? I saw the gemini has some DMA engine
> but I never saw a driver for it. It looks like a reasonable thing to do to
> my untrained DMA eye.
We should never use dma_coerce_mask_and_coherent() for new code, it's
only needed for broken platforms without DT.
A 32-bit mask is set by default.
Arnd
next prev parent reply other threads:[~2017-02-10 20:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 20:00 [PATCH 0/3] usb: add device tree support for fotg2-hcd driver Hans Ulli Kroll
2017-02-08 20:00 ` [PATCH 1/3] usb: host: fotg2: add devicetree probing Hans Ulli Kroll
2017-02-08 23:51 ` kbuild test robot
2017-02-09 4:27 ` kbuild test robot
2017-02-09 14:20 ` [PATCH 1/3 v2] usb: host: fotg2: add device tree probing Hans Ulli Kroll
2017-02-10 13:12 ` Linus Walleij
2017-02-10 20:26 ` Arnd Bergmann [this message]
2017-02-17 11:02 ` Hans Ulli Kroll
2017-02-10 13:34 ` Greg Kroah-Hartman
2017-02-17 11:06 ` [PATCH 1/3 v3] " Hans Ulli Kroll
2017-02-08 20:00 ` [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller Hans Ulli Kroll
2017-02-10 13:14 ` Linus Walleij
2017-02-15 23:00 ` Rob Herring
2017-02-17 10:07 ` Hans Ulli Kroll
2017-02-21 14:43 ` Rob Herring
2017-03-29 23:16 ` Linus Walleij
2017-03-30 18:31 ` Hans Ulli Kroll
2017-04-22 0:22 ` Linus Walleij
2017-02-08 20:00 ` [PATCH 3/3] DT: add Faraday Tec. as vendor Hans Ulli Kroll
2017-02-10 13:16 ` Linus Walleij
2017-02-11 3:04 ` Joel Stanley
2017-02-12 20:37 ` Linus Walleij
2017-02-15 23:02 ` Rob Herring
2017-02-10 13:24 ` [PATCH 0/3] usb: add device tree support for fotg2-hcd driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3421824.lhyKKsOD1E@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).