From: Arnd Bergmann <arnd@arndb.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jeremy Kerr <jeremy.kerr@au1.ibm.com>,
Rob Herring <robherring2@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Olof Johansson <olof@lixom.net>,
Grant Likely <grant.likely@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] drivers/core/of: Add symlink to device-tree from devices with an OF node
Date: Wed, 19 Nov 2014 09:38:13 +0100 [thread overview]
Message-ID: <3422452.OFUjscQXRB@wuerfel> (raw)
In-Reply-To: <1416364544.5704.23.camel@kernel.crashing.org>
On Wednesday 19 November 2014 13:35:44 Benjamin Herrenschmidt wrote:
> On Wed, 2014-11-19 at 10:39 +1100, Jeremy Kerr wrote:
> > Hi Rob,
> >
> > >> diff --git a/drivers/base/core.c b/drivers/base/core.c
> > >> index 20da3ad..8c7b607 100644
> > >> --- a/drivers/base/core.c
> > >> +++ b/drivers/base/core.c
> > >> @@ -493,6 +493,15 @@ static int device_add_attrs(struct device *dev)
> > >> goto err_remove_dev_groups;
> > >> }
> > >>
> > >> +#ifdef CONFIG_OF
> > >> + if (dev->of_node) {
> > >
> > > if (IS_ENABLED(CONFIG_OF) && dev->of_node)
> >
> > struct device doesn't have an of_node member if !CONFIG_OF, so we'll
> > need to disable this block in the preprocessor.
>
> Actually that's no longer the case since 2.6.39 afaik
I wonder if we should create a small helper for this, like
static inline struct device_node *dev_of_node(struct device *of_node)
{
if (!IS_ENABLED(CONFIG_OF))
return NULL;
return dev->of_node;
}
Adding the IS_ENABLED() in a lot of drivers isn't horrible, but we seem
to be doing it a lot.
Arnd
next prev parent reply other threads:[~2014-11-19 8:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 6:33 [RFC] Add of_path property for all devices with a node Benjamin Herrenschmidt
2014-11-07 6:35 ` Benjamin Herrenschmidt
2014-11-10 5:17 ` Benjamin Herrenschmidt
2014-11-10 14:06 ` Rob Herring
2014-11-10 22:48 ` Benjamin Herrenschmidt
2014-11-13 1:10 ` [PATCH] drivers/core/of: Add symlink to device-tree from devices with an OF node Benjamin Herrenschmidt
2014-11-18 16:37 ` Rob Herring
2014-11-18 23:39 ` Jeremy Kerr
2014-11-18 23:53 ` Jeremy Kerr
2014-11-19 2:35 ` Benjamin Herrenschmidt
2014-11-19 8:38 ` Arnd Bergmann [this message]
2014-11-19 14:45 ` Rob Herring
2014-11-19 14:49 ` Arnd Bergmann
2014-11-19 15:39 ` Rob Herring
2014-11-19 16:30 ` Grant Likely
2014-11-19 2:30 ` Benjamin Herrenschmidt
2014-11-27 3:39 ` Greg KH
2014-11-27 6:24 ` Benjamin Herrenschmidt
2014-11-18 15:18 ` [RFC] Add of_path property for all devices with a node Grant Likely
2014-11-19 2:25 ` Benjamin Herrenschmidt
2015-02-18 0:25 ` [PATCH 2/2 v3] drivers/core/of: Add symlink to device-tree from devices with an OF node Benjamin Herrenschmidt
2015-02-18 1:07 ` Rob Herring
2015-02-18 4:57 ` Greg Kroah-Hartman
2015-02-18 9:50 ` Benjamin Herrenschmidt
2015-03-10 14:22 ` Rob Herring
2015-03-10 15:11 ` Greg Kroah-Hartman
2015-02-18 4:57 ` Greg Kroah-Hartman
2014-11-13 4:28 ` [RFC] Add of_path property for all devices with a node Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3422452.OFUjscQXRB@wuerfel \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.kerr@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).