From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: oliver.brown@nxp.com, Sandor.yu@nxp.com, linux-imx@nxp.com,
kernel@pengutronix.de, Sandor Yu <Sandor.yu@nxp.com>
Subject: Re: [PATCH v6 2/8] dt-bindings: display: bridge: Add Cadence MHDP8501 HDMI and DP
Date: Fri, 16 Jun 2023 11:31:43 +0200 [thread overview]
Message-ID: <3439354.PYKUYFuaPT@steina-w> (raw)
In-Reply-To: <8687f2221299b120e12f29fdccf264e120227bd7.1686729444.git.Sandor.yu@nxp.com>
Hi Sandor,
Am Donnerstag, 15. Juni 2023, 03:38:12 CEST schrieb Sandor Yu:
> Add bindings for Cadence MHDP8501 DisplayPort and HDMI driver.
>
> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
> ---
> .../display/bridge/cdns,mhdp8501.yaml | 105 ++++++++++++++++++
> 1 file changed, 105 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml new
> file mode 100644
> index 000000000000..a54756815e6f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp8501.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cadence MHDP8501 Displayport bridge
> +
> +maintainers:
> + - Sandor Yu <Sandor.yu@nxp.com>
> +
> +description:
> + The Cadence MHDP8501 Displayport/HDMI TX interface.
> +
> +properties:
> + compatible:
> + enum:
> + - cdns,mhdp8501-dp
> + - cdns,mhdp8501-hdmi
> + - fsl,imx8mq-mhdp8501-dp
> + - fsl,imx8mq-mhdp8501-hdmi
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description: MHDP8501 DP/HDMI APB clock.
> +
> + phys:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Hotplug cable plugin.
> + - description: Hotplug cable plugout.
> +
> + interrupt-names:
> + items:
> + - const: plug_in
> + - const: plug_out
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Input port from display controller output.
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Output port to DP/HDMI connector.
> +
> + required:
> + - port@0
> + - port@1
You mark these ports as required, but apparently the drivers do not use them,
AFAICT. E.g. missing port@1 is not resulting in an error, at lease for HDMI
one.
Best regards,
Alexander
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - interrupts
> + - interrupt-names
> + - phys
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx8mq-clock.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + mhdp_dp: dp-bridge@32c00000 {
> + compatible = "fsl,imx8mq-mhdp8501-dp";
> + reg = <0x32c00000 0x100000>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "plug_in", "plug_out";
> + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> + phys = <&dp_phy>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + mhdp_in: endpoint {
> + remote-endpoint = <&dcss_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + mhdp_out: endpoint {
> + remote-endpoint = <&dp_con>;
> + };
> + };
> + };
> + };
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2023-06-16 9:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 1:38 [PATCH v6 0/8] Initial support for Cadence MHDP8501(HDMI/DP) for i.MX8MQ Sandor Yu
2023-06-15 1:38 ` [PATCH v6 1/8] drm: bridge: Cadence: convert mailbox functions to macro functions Sandor Yu
2023-06-15 1:38 ` [PATCH v6 2/8] dt-bindings: display: bridge: Add Cadence MHDP8501 HDMI and DP Sandor Yu
2023-06-16 9:31 ` Alexander Stein [this message]
2023-06-19 3:10 ` [EXT] " Sandor Yu
2023-06-20 15:37 ` Rob Herring
2023-06-20 15:48 ` Rob Herring
2023-06-21 2:23 ` [EXT] " Sandor Yu
2023-06-21 8:14 ` Krzysztof Kozlowski
2023-06-15 1:38 ` [PATCH v6 3/8] drm: bridge: Cadence: Add MHDP8501 DP driver Sandor Yu
2023-06-15 16:33 ` Sam Ravnborg
2023-06-16 7:13 ` [EXT] " Sandor Yu
2023-06-15 1:38 ` [PATCH v6 4/8] phy: Add HDMI configuration options Sandor Yu
2023-06-21 11:22 ` Vinod Koul
2023-07-10 7:28 ` [EXT] " Sandor Yu
2023-06-24 18:02 ` Dmitry Baryshkov
2023-07-10 7:28 ` [EXT] " Sandor Yu
2023-07-10 7:30 ` Dmitry Baryshkov
2023-07-10 7:41 ` Sandor Yu
2023-07-10 7:44 ` Dmitry Baryshkov
2023-07-10 8:01 ` Sandor Yu
2023-07-10 8:05 ` Dmitry Baryshkov
2023-07-10 8:11 ` Sandor Yu
2023-06-15 1:38 ` [PATCH v6 5/8] drm: bridge: Cadence: Add MHDP8501 HDMI driver Sandor Yu
2023-06-16 9:29 ` Alexander Stein
2023-06-19 3:11 ` [EXT] " Sandor Yu
2023-06-19 5:35 ` Alexander Stein
2023-06-15 1:38 ` [PATCH v6 6/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY Sandor Yu
2023-06-16 9:34 ` Alexander Stein
2023-06-19 3:10 ` [EXT] " Sandor Yu
2023-06-15 1:38 ` [PATCH v6 7/8] phy: freescale: Add DisplayPort PHY driver for i.MX8MQ Sandor Yu
2023-06-21 11:24 ` Vinod Koul
2023-07-10 7:30 ` [EXT] " Sandor Yu
2023-06-15 1:38 ` [PATCH v6 8/8] phy: freescale: Add HDMI " Sandor Yu
2023-06-21 11:57 ` Vinod Koul
2023-07-10 7:30 ` [EXT] " Sandor Yu
2023-06-16 9:37 ` [PATCH v6 0/8] Initial support for Cadence MHDP8501(HDMI/DP) " Alexander Stein
2023-09-21 14:29 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3439354.PYKUYFuaPT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Sandor.yu@nxp.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=oliver.brown@nxp.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).