From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: mtk.manpages@gmail.com, Andrea Arcangeli <aarcange@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-man@vger.kernel.org
Subject: Re: [PATCH man-pages 3/5] ioctl_userfaultfd.2: add BUGS section
Date: Mon, 1 May 2017 20:33:50 +0200 [thread overview]
Message-ID: <345c064d-83fe-3e40-c5cb-5d4b6e5cdff4@gmail.com> (raw)
In-Reply-To: <1493617399-20897-4-git-send-email-rppt@linux.vnet.ibm.com>
Hi Mike,
I've applied this, but have a question.
On 05/01/2017 07:43 AM, Mike Rapoport wrote:
> The features handshake is not quite convenient.
> Elaborate about it in the BUGS section.
>
> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> ---
> man2/ioctl_userfaultfd.2 | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> index e12b9de..50316de 100644
> --- a/man2/ioctl_userfaultfd.2
> +++ b/man2/ioctl_userfaultfd.2
> @@ -650,6 +650,15 @@ operations are Linux-specific.
> .SH EXAMPLE
> See
> .BR userfaultfd (2).
> +.SH BUGS
> +In order to detect available userfault features and
> +enable certain subset of those features
I changed "certain" to "some". ("certain subset" here also
would sound like "some particular subset" of those features.)
Okay?
> +the usefault file descriptor must be closed after the first
> +.BR UFFDIO_API
> +operation that queries features availability and re-opened before
> +the second
> +.BR UFFDIO_API
> +call that actually enables the desired features.
> .SH SEE ALSO
> .BR ioctl (2),
> .BR mmap (2),
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2017-05-01 18:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 5:43 [PATCH man-pages 0/5] {ioctl_}userfaultfd.2: yet another update Mike Rapoport
2017-05-01 5:43 ` [PATCH man-pages 1/5] ioctl_userfaultfd.2: update description of shared memory areas Mike Rapoport
2017-05-01 18:33 ` Michael Kerrisk (man-pages)
2017-05-02 9:31 ` Mike Rapoport
2017-05-02 20:23 ` Michael Kerrisk (man-pages)
2017-05-01 5:43 ` [PATCH man-pages 2/5] ioctl_userfaultfd.2: UFFDIO_COPY: add ENOENT and ENOSPC description Mike Rapoport
2017-05-01 18:33 ` Michael Kerrisk (man-pages)
2017-05-01 5:43 ` [PATCH man-pages 3/5] ioctl_userfaultfd.2: add BUGS section Mike Rapoport
2017-05-01 18:33 ` Michael Kerrisk (man-pages) [this message]
2017-05-02 9:32 ` Mike Rapoport
2017-05-01 5:43 ` [PATCH man-pages 4/5] userfaultfd.2: add note about asynchronios events delivery Mike Rapoport
2017-05-01 18:33 ` Michael Kerrisk (man-pages)
2017-05-02 9:46 ` Mike Rapoport
2017-05-02 20:27 ` Michael Kerrisk (man-pages)
2017-05-01 5:43 ` [PATCH man-pages 5/5] userfaultfd.2: update VERSIONS section with 4.11 chanegs Mike Rapoport
2017-05-01 18:33 ` Michael Kerrisk (man-pages)
2017-05-01 18:34 ` [PATCH man-pages 0/5] {ioctl_}userfaultfd.2: yet another update Michael Kerrisk (man-pages)
2017-05-02 9:48 ` Mike Rapoport
2017-05-02 20:28 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345c064d-83fe-3e40-c5cb-5d4b6e5cdff4@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=aarcange@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).