From: Arnd Bergmann <arnd@arndb.de>
To: Xunlei Pang <xlpang@126.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
John Stultz <john.stultz@linaro.org>,
Xunlei Pang <pang.xunlei@linaro.org>,
Carlo Caione <carlo.caione@gmail.com>
Subject: Re: [PATCH RESEND 3/3] drivers/rtc/sunxi: Replace deprecated rtc_tm_to_time()
Date: Mon, 01 Jun 2015 21:53:03 +0200 [thread overview]
Message-ID: <3461238.S8UhmYfQDn@wuerfel> (raw)
In-Reply-To: <1432911877-607-3-git-send-email-xlpang@126.com>
On Friday 29 May 2015 23:04:37 Xunlei Pang wrote:
> }
>
> - rtc_tm_to_time(alrm_tm, &time_set);
> - rtc_tm_to_time(&tm_now, &time_now);
> + time_set = rtc_tm_to_time64(alrm_tm);
> + time_now = rtc_tm_to_time64(&tm_now);
> if (time_set <= time_now) {
> dev_err(dev, "Date to set in the past\n");
> return -EINVAL;
> }
>
> + if (time_set > time_now + 255 * SEC_IN_DAY) {
> + dev_err(dev, "Day must be in the range 0 - 255\n");
> + return -EINVAL;
> + }
> +
>
So this driver also uses the two values just to do a comparison
and to take the difference in seconds.
If we have a helper function that returns the difference between
two rtc_tm values as a time64_t, we can use that for both
this driver and isl1208.
Arnd
next prev parent reply other threads:[~2015-06-01 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 15:04 [PATCH RESEND 1/3] drivers/rtc/pcf8563: Replace deprecated rtc_time_to_tm() and rtc_tm_to_time() Xunlei Pang
2015-05-29 15:04 ` [PATCH RESEND 2/3] drivers/rtc/isl1208: Replace deprecated rtc_tm_to_time() Xunlei Pang
2015-06-01 19:49 ` Arnd Bergmann
2015-05-29 15:04 ` [PATCH RESEND 3/3] drivers/rtc/sunxi: " Xunlei Pang
2015-06-01 19:53 ` Arnd Bergmann [this message]
2015-06-02 3:21 ` pang.xunlei
2015-06-01 19:46 ` [PATCH RESEND 1/3] drivers/rtc/pcf8563: Replace deprecated rtc_time_to_tm() and rtc_tm_to_time() Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3461238.S8UhmYfQDn@wuerfel \
--to=arnd@arndb.de \
--cc=a.zummo@towertech.it \
--cc=carlo.caione@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=rtc-linux@googlegroups.com \
--cc=xlpang@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).