From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: gregkh@linuxfoundation.org, Phillip Potter <phil@philpotter.co.uk>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
martin@kaiser.cx, straube.linux@gmail.com,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH 2/6] staging: r8188eu: remove unused function dump_txrpt_ccx_88e
Date: Thu, 19 Aug 2021 03:38:41 +0200 [thread overview]
Message-ID: <3469308.GW2Jk8YpuN@localhost.localdomain> (raw)
In-Reply-To: <20210818234253.208271-3-phil@philpotter.co.uk>
On Thursday, August 19, 2021 1:42:49 AM CEST Phillip Potter wrote:
> Remove unused function dump_txrpt_ccx_88e from hal/rtl8188e_xmit.c and
> remove its declaration in include/rtl8188e_xmit.h, as this function is
> not called from anywhere, and is thus dead code.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/hal/rtl8188e_xmit.c | 22 -------------------
> .../staging/r8188eu/include/rtl8188e_xmit.h | 1 -
> 2 files changed, 23 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> index d2b55d581f95..46b871f3f631 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> @@ -7,28 +7,6 @@
> #include "../include/drv_types.h"
> #include "../include/rtl8188e_hal.h"
>
> -void dump_txrpt_ccx_88e(void *buf)
> -{
> - struct txrpt_ccx_88e *txrpt_ccx = (struct txrpt_ccx_88e *)buf;
> -
> - DBG_88E("%s:\n"
> - "tag1:%u, pkt_num:%u, txdma_underflow:%u, int_bt:%u, int_tri:%u, int_ccx:%u\n"
> - "mac_id:%u, pkt_ok:%u, bmc:%u\n"
> - "retry_cnt:%u, lifetime_over:%u, retry_over:%u\n"
> - "ccx_qtime:%u\n"
> - "final_data_rate:0x%02x\n"
> - "qsel:%u, sw:0x%03x\n",
> - __func__, txrpt_ccx->tag1, txrpt_ccx->pkt_num,
> - txrpt_ccx->txdma_underflow, txrpt_ccx->int_bt,
> - txrpt_ccx->int_tri, txrpt_ccx->int_ccx,
> - txrpt_ccx->mac_id, txrpt_ccx->pkt_ok, txrpt_ccx->bmc,
> - txrpt_ccx->retry_cnt, txrpt_ccx->lifetime_over,
> - txrpt_ccx->retry_over, txrpt_ccx_qtime_88e(txrpt_ccx),
> - txrpt_ccx->final_data_rate, txrpt_ccx->qsel,
> - txrpt_ccx_sw_88e(txrpt_ccx)
> - );
> -}
> -
> void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf)
> {
> struct txrpt_ccx_88e *txrpt_ccx = (struct txrpt_ccx_88e *)buf;
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> index d2099da1a41a..20b55e3850ba 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> @@ -150,7 +150,6 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *padapter,
> struct xmit_priv *pxmitpriv,
> struct xmit_buf *pxmitbuf);
>
> -void dump_txrpt_ccx_88e(void *buf);
> void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf);
>
> #endif /* __RTL8188E_XMIT_H__ */
> --
> 2.31.1
>
At a quick look it looks good.
Built with "make C=2 -j8 drivers/staging/r8188eu/ W=1"
on x86-64, it does not introduce any errors or warnings, so...
Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Thanks,
Fabio
next prev parent reply other threads:[~2021-08-19 1:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 23:42 [PATCH 0/6] staging: r8188eu: HAL related cleanups Phillip Potter
2021-08-18 23:42 ` [PATCH 1/6] staging: r8188eu: remove _dbg_dump_tx_info function Phillip Potter
2021-08-19 1:34 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 2/6] staging: r8188eu: remove unused function dump_txrpt_ccx_88e Phillip Potter
2021-08-19 1:38 ` Fabio M. De Francesco [this message]
2021-08-18 23:42 ` [PATCH 3/6] staging: r8188eu: remove txrpt_ccx_sw_88e and txrpt_ccx_qtime_88e macros Phillip Potter
2021-08-19 1:56 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 4/6] staging: r8188eu: remove empty function rtl8188eu_free_xmit_priv Phillip Potter
2021-08-19 2:00 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 5/6] staging: r8188eu: remove function rtw_hal_free_xmit_priv Phillip Potter
2021-08-19 2:08 ` Fabio M. De Francesco
2021-08-18 23:42 ` [PATCH 6/6] staging: r8188eu: remove free_xmit_priv field from struct hal_ops Phillip Potter
2021-08-19 3:14 ` Fabio M. De Francesco
2021-08-20 21:56 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3469308.GW2Jk8YpuN@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).