From: Jakob Koschel <jakobkoschel@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Cristian Birsan <cristian.birsan@microchip.com>,
Al Cooper <alcooperx@gmail.com>, Li Yang <leoyang.li@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Michal Simek <michal.simek@xilinx.com>,
"open list:USB GADGET/PERIPHERAL SUBSYSTEM"
<linux-usb@vger.kernel.org>, Mike Rapoport <rppt@kernel.org>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH 01/26] usb: gadget: fsl: remove usage of list iterator past the loop body
Date: Sun, 6 Mar 2022 20:19:46 +0100 [thread overview]
Message-ID: <34D2D040-8BF4-4F70-830D-0715A8BE7873@gmail.com> (raw)
In-Reply-To: <CAHk-=wheru6rEfzC2wuO9k03PRF6s3nhxryCAnwR5bzKwPV2ww@mail.gmail.com>
> On 6. Mar 2022, at 19:39, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Sun, Mar 6, 2022 at 9:51 AM Jakob Koschel <jakobkoschel@gmail.com> wrote:
>>
>> /* make sure it's actually queued on this endpoint */
>> - list_for_each_entry(req, &ep->queue, queue) {
>> - if (&req->req == _req)
>> + list_for_each_entry(tmp, &ep->queue, queue) {
>> + if (&tmp->req == _req) {
>> + req = tmp;
>> break;
>> + }
>> }
>
> Honestly, I think many (most?) of these would be a lot cleaner as
>
> list_for_each_entry(tmp, &ep->queue, queue) {
> if (&tmp->req != _req)
> continue;
> req = tmp;
> break;
> }
Alright, then I'll go ahead and adjust them. I tried keeping the code
as similar as possible because in other cases it might be less cleaner
inverting the condition.
>
> and in fact maybe that 'tmp' would be better named 'iter' or similar
> (maybe 'pos', which is what the list.h macros themselves use for the
> iterator naming), just from a naming standpoint.
I agree, also here I simply kept it to what we concluded in the other
thread. I also think using 'iter' would make more sense.
>
> Because it's not really some temporary variable, it has a real use.
>
> Linus
Jakob
next prev parent reply other threads:[~2022-03-06 19:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 17:50 [PATCH 00/26] usb: gadget: remove usage of list iterator past the loop Jakob Koschel
2022-03-06 17:50 ` [PATCH 01/26] usb: gadget: fsl: remove usage of list iterator past the loop body Jakob Koschel
2022-03-06 18:39 ` Linus Torvalds
2022-03-06 19:19 ` Jakob Koschel [this message]
2022-03-06 17:50 ` [PATCH 02/26] usb: gadget: bdc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 03/26] usb: gadget: udc: atmel: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 04/26] usb: gadget: udc: pxa25x: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 05/26] usb: gadget: udc: at91: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 06/26] usb: gadget: goku_udc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 07/26] usb: gadget: udc: gr_udc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 08/26] usb: gadget: lpc32xx_udc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 09/26] usb: gadget: mv_u3d: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 10/26] usb: gadget: udc: mv_udc_core: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 11/26] usb: gadget: net2272: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 12/26] usb: gadget: udc: net2280: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 13/26] usb: gadget: omap_udc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 14/26] usb: gadget: s3c-hsudc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 15/26] usb: gadget: udc-xilinx: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 16/26] usb: gadget: aspeed: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 17/26] usb: gadget: configfs: remove using list iterator after loop body as a ptr Jakob Koschel
2022-03-06 17:50 ` [PATCH 18/26] usb: gadget: legacy: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 19/26] usb: gadget: udc: max3420_udc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 20/26] usb: gadget: tegra-xudc: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 21/26] usb: gadget: composite: remove check of list iterator against head past the loop body Jakob Koschel
2022-03-06 17:50 ` [PATCH 22/26] usb: gadget: pxa27x_udc: replace usage of rc to check if a list element was found Jakob Koschel
2022-03-06 17:50 ` [PATCH 23/26] usb: gadget: udc: s3c2410: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 24/26] usb: gadget: udc: core: " Jakob Koschel
2022-03-06 17:50 ` [PATCH 25/26] usb: gadget: dummy_hcd: " Jakob Koschel
2022-03-06 18:00 ` Greg KH
2022-03-06 19:16 ` Jakob Koschel
2022-03-06 17:50 ` [PATCH 26/26] usb: gadget: udc: s3c2410: " Jakob Koschel
2022-03-07 12:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34D2D040-8BF4-4F70-830D-0715A8BE7873@gmail.com \
--to=jakobkoschel@gmail.com \
--cc=alcooperx@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alim.akhtar@samsung.com \
--cc=andrew@aj.id.au \
--cc=balbi@kernel.org \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=claudiu.beznea@microchip.com \
--cc=cristian.birsan@microchip.com \
--cc=daniel@zonque.org \
--cc=greg@kroah.com \
--cc=h.j.bos@vu.nl \
--cc=haojian.zhuang@gmail.com \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nicolas.ferre@microchip.com \
--cc=robert.jarzmik@free.fr \
--cc=rppt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).