From: Jaroslav Kysela <perex@perex.cz>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: tiwai@suse.com, Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Skip creating captures in SOF context
Date: Wed, 20 Jul 2022 09:52:37 +0200 [thread overview]
Message-ID: <34bddb2f-dc57-c08c-358e-26cf7824c203@perex.cz> (raw)
In-Reply-To: <CAAd53p6ru7CJ=pJ2knCL5pgU_Y+nA=yTPscKk225zTD-fv4qQg@mail.gmail.com>
Dne 20. 07. 22 v 3:45 Kai-Heng Feng napsal(a):
> On Tue, Jul 19, 2022 at 11:41 PM Jaroslav Kysela <perex@perex.cz> wrote:
>>
>> Dne 19. 07. 22 v 16:47 Kai-Heng Feng napsal(a):
>>> On HP laptops that use SOF driver for DMIC, the micmute LED doesn't
>>> light up when mic is muted after commit 9b014266ef8a ("ASoC: SOF:
>>> topology: use new sound control LED layer").
>>>
>>> The micmute LED itself is still working via sysfs, but it doesn't follow
>>> mute anymore. That's because unlike vendors like Dell and Lenovo, HP
>>> laptops use HDA codec to control mute LEDs instead of ACPI. So on HP
>>> laptops, both SOF and HDA create captures with
>>> SNDRV_CTL_ELEM_ACCESS_MIC_LED access, snd_ctl_led_set_state() considers
>>> there are two different kcontrols and one of them is not muted.
>>
>> It does not mean that it's a wrong behavior. When both controls are muted, the
>> LED should be turned on. It just requires that all inputs are off (and it may
>> be the default - probably we can set in UCM or so). If you turn the "Capture
>> Switch" off in amixer / alsamixer, do things work as expected ?
>
> Yes. When all captures are muted the micmute LED is on.
>
>>
>>> So skip creating captures for HDA when it's called from SOF, the
>>> captures are already handled by SOF.
>>
>> The capture controls are for other inputs like external analog microphone. If
>> it is required to suppress the MIC LED for some hardware, just skip the
>> "spec->mic_mute_led = 1" assignment in hda_generic.c . Also, the check
>> "codec->core.type != HDA_DEV_ASOC" is not sufficient, because you don't know,
>> if the topology really sets the MIC LED flag.
>
> AFAIK the external analog microphone on DMIC laptop is driven by SOF driver too.
> If those capture controls are indeed needed for external analog mics,
> use UCM to mute them by default won't work either.
Could you describe this ? I though that only DMIC is handled by SOF when HDA
codec is in the system. There is a separate analog codec for external analog
microphone or the HDA codec is somehow connected to SOF/DSP ? If so, how ?
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2022-07-20 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 14:47 [PATCH] ALSA: hda: Skip creating captures in SOF context Kai-Heng Feng
2022-07-19 15:41 ` Jaroslav Kysela
2022-07-20 1:45 ` Kai-Heng Feng
2022-07-20 6:29 ` Takashi Iwai
2022-07-20 7:52 ` Jaroslav Kysela [this message]
2022-07-20 13:31 ` Pierre-Louis Bossart
2022-08-15 7:55 ` Kai-Heng Feng
2023-01-05 12:36 ` Kai-Heng Feng
2023-01-05 12:43 ` Jaroslav Kysela
2023-01-06 5:00 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34bddb2f-dc57-c08c-358e-26cf7824c203@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).