From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Sebastian Reichel <sre@kernel.org>,
Tony Lindgren <tony@atomide.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<dri-devel@lists.freedesktop.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv1 03/14] drm/omap: plane: update fifo size on ovl setup
Date: Fri, 1 Dec 2017 14:10:42 +0200 [thread overview]
Message-ID: <34c2588e-7d7e-219f-fd34-9a441d46e0cc@ti.com> (raw)
In-Reply-To: <20170724173311.27170-4-sebastian.reichel@collabora.co.uk>
On 24/07/17 20:33, Sebastian Reichel wrote:
> This is a workaround for a hardware bug occuring on OMAP3
> with manually updated panels. Details about the HW bug are
> unknown to me, but without this fix the panel refresh does
> not work at all on Nokia N950.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index fd7504b37e3b..b6dca5ee34d4 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -1398,6 +1398,18 @@ void dispc_ovl_compute_fifo_thresholds(enum omap_plane_id plane,
> }
> }
>
> +void dispc_ovl_set_manual_fifo_threshold(enum omap_plane_id plane)
> +{
> + u32 fifo_low, fifo_high;
> + bool use_fifo_merge = false;
> + bool use_manual_update = true;
> +
> + dispc_ovl_compute_fifo_thresholds(plane, &fifo_low, &fifo_high,
> + use_fifo_merge, use_manual_update);
> +
> + dispc_ovl_set_fifo_threshold(plane, fifo_low, fifo_high);
> +}
> +
> static void dispc_ovl_set_mflag(enum omap_plane_id plane, bool enable)
> {
> int bit;
> @@ -2566,6 +2578,10 @@ static int dispc_ovl_setup(enum omap_plane_id plane,
> oi->zorder, oi->pre_mult_alpha, oi->global_alpha,
> oi->rotation_type, replication, vm, mem_to_mem);
>
> + /* manual mode needs other fifo thresholds */
> + if (mgr_fld_read(channel, DISPC_MGR_FLD_STALLMODE))
> + dispc_ovl_set_manual_fifo_threshold(plane);
> +
> return r;
> }
We don't have the stallmode for all channels. And on OMAP2 it's for
RFBI, and I don't know if that needs different thresholds or not. Also,
I'm not sure if OMAP4-5 DSI needs this. And I think it's good to mention
the unknown bug in the comment too. And yes, it's unknown to me too, I
never figured it out. These thresholds just seemed to work, while the
default did not.
So I think we need to check that the platform is OMAP3 and channel is
LCD. We can later extend that to cover OMAP4-5 if needed.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2017-12-01 12:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 17:32 [PATCHv1 00/14] omapdrm: DSI command mode panel support Sebastian Reichel
2017-07-24 17:32 ` [PATCHv1 01/14] drm/omap: remove unused function defines Sebastian Reichel
2017-07-26 10:39 ` Pavel Machek
2017-12-01 12:30 ` Tomi Valkeinen
2017-07-24 17:32 ` [PATCHv1 02/14] drm/omap: drop incorrect comment Sebastian Reichel
2017-07-26 10:40 ` Pavel Machek
2017-07-24 17:33 ` [PATCHv1 03/14] drm/omap: plane: update fifo size on ovl setup Sebastian Reichel
2017-12-01 12:10 ` Tomi Valkeinen [this message]
2017-12-01 12:25 ` Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 04/14] drm/omap: add framedone interrupt support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 05/14] drm/omap: add manual update detection helper Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 06/14] drm/omap: add support for manually updated displays Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 07/14] drm/omap: add support for physical size hints from display drivers Sebastian Reichel
2017-07-26 10:41 ` Pavel Machek
2017-07-24 17:33 ` [PATCHv1 08/14] drm/omap: panel-dsi-cm: fix driver Sebastian Reichel
2017-12-01 12:28 ` Tomi Valkeinen
2017-07-24 17:33 ` [PATCHv1 09/14] drm/omap: panel-dsi-cm: add regulator support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 10/14] drm/omap: panel-dsi-cm: add physical size support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 11/14] drm/omap: panel-dsi-cm: add external backlight support Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 12/14] drm/omap: panel-dsi-cm: switch to gpiod Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 13/14] ARM: dts: omap4-droid4: improve LCD description Sebastian Reichel
2017-07-24 17:33 ` [PATCHv1 14/14] ARM: dts: n950: add display support Sebastian Reichel
2017-07-26 10:41 ` Pavel Machek
2017-07-27 12:02 ` [PATCHv1 00/14] omapdrm: DSI command mode panel support Tony Lindgren
2017-09-29 13:26 ` Sebastian Reichel
2017-10-12 8:45 ` Tomi Valkeinen
2017-10-13 17:12 ` Tony Lindgren
2017-10-23 22:01 ` Sebastian Reichel
2017-10-26 11:59 ` Tomi Valkeinen
2017-10-27 18:00 ` Sebastian Reichel
2017-11-06 10:29 ` Pavel Machek
2017-12-01 12:58 ` Tomi Valkeinen
2017-12-08 18:01 ` Sebastian Reichel
2017-12-11 8:30 ` Tomi Valkeinen
2018-02-08 9:41 ` Pavel Machek
2018-02-08 10:53 ` Tomi Valkeinen
2018-02-08 18:30 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c2588e-7d7e-219f-fd34-9a441d46e0cc@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).