From: zhengyongjun <zhengyongjun3@huawei.com>
To: "bryan.whitehead@microchip.com" <bryan.whitehead@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH net-next] net: microchip: Remove set but not used variable
Date: Sat, 19 Sep 2020 03:08:57 +0000 [thread overview]
Message-ID: <34c5c342e3bb4b778ba39d5535377da3@huawei.com> (raw)
In-Reply-To: <20200919023909.23716-1-zhengyongjun3@huawei.com>
This is the bad patch, my fault, I forget to check patch title, please ignore it, thank you very much.
-----邮件原件-----
发件人: zhengyongjun
发送时间: 2020年9月19日 10:39
收件人: bryan.whitehead@microchip.com; UNGLinuxDriver@microchip.com; davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: zhengyongjun <zhengyongjun3@huawei.com>
主题: [PATCH net-next] net: microchip: Remove set but not used variable
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
`ret` is set but not used, so check it's value.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index de93cc6ebc1a..56a1b5928f9a 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev)
/* Host sets PME_En, put D3hot */
ret = pci_prepare_to_sleep(pdev);
- return 0;
+ return ret;
}
static int lan743x_pm_resume(struct device *dev)
--
2.17.1
next prev parent reply other threads:[~2020-09-19 3:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 2:39 [PATCH net-next] net: microchip: Remove set but not used variable Zheng Yongjun
2020-09-19 3:08 ` zhengyongjun [this message]
2020-09-19 21:09 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-09-19 2:37 Zheng Yongjun
2020-09-19 3:02 ` 答复: " zhengyongjun
2020-09-19 21:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c5c342e3bb4b778ba39d5535377da3@huawei.com \
--to=zhengyongjun3@huawei.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).