* Re: [PATCH v2] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
@ 2020-04-21 9:00 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-21 9:00 UTC (permalink / raw)
To: Bernard Zhao, amd-gfx, dri-devel, Alex Deucher,
Christian König, Chunming Zhou
Cc: linux-kernel, opensource.kernel, Andrzej Pietrasiewicz,
Daniel Vetter, David Airlie, José Roberto de Souza,
Lyude Paul, Sam Ravnborg
> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.
I suggest to improve the commit message.
* Are you still unsure about the next changes?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ae83d0b416db002fe95601e7f97f64b59514d936#n151
* Would you like to adjust the patch subject another bit?
* How do you think about to add the tag “Fixes”
because of adjustments for the exception handling?
It can be nicer if all patch reviewers (including me) will be explicitly specified
as recipients for such messages, can't it?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-21 9:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 9:00 [PATCH v2] drm/amdgpu: Return more error codes in amdgpu_connector_set_property() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).