Re: [PATCH] ASoC: codecs: allow compile testing without MFD drivers

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: allow compile testing without MFD drivers
Date: Tue, 30 Aug 2022 13:51:16 +0300	[thread overview]
Message-ID: <34fd836d-56f1-3d88-0571-349aef95fe96@linaro.org> (raw)
In-Reply-To: <Yw3oA6pVp3PMxfA3@sirena.org.uk>

On 30/08/2022 13:35, Mark Brown wrote:
> On Sat, Aug 27, 2022 at 12:02:39PM +0300, Krzysztof Kozlowski wrote:
> 
>> True, it's not the same build coverage need as subsystem/interface
>> dependencies, but still:
>> 1. Drivers can be built independently, so why not?
>> 2. There is no drawback in allowing to building them independently
>> (compile test).
>> 3. The parent MFD device could also depend on something (RK817 and
>> MFD_LOCHNAGAR depends on I2C and OF; CPCAP on SPI), so it's not always
>> the case of just enabling parent. IOW, you can compile test codecs
>> without I2C and SPI which is valuable itself.
> 
>> I find the last reason actually quite valid and applicable here. If you
>> wish I can add it to the commit msg.
> 
> You've already found one case where there's a dependency being
> pulled in by the parent, I suspect there's more.  There's a
> tradeoff between getting coverage and having to deal with the
> noise from randconfigs.

Yeah, that was my mistake because did not spot it has "select
REGMAP_I2C". For such cases the benefit is indeed gone.

Best regards,
Krzysztof