From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754097AbdDQPKq (ORCPT ); Mon, 17 Apr 2017 11:10:46 -0400 Received: from mout.web.de ([217.72.192.78]:53298 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753427AbdDQPKo (ORCPT ); Mon, 17 Apr 2017 11:10:44 -0400 Subject: [PATCH 02/25] net: mvneta: Improve two size determinations in mvneta_init() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <34ff173b-9727-ff30-677b-f27c54c7c0bd@users.sourceforge.net> Date: Mon, 17 Apr 2017 17:10:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Pnda5bkmQnwNy4kmsY8S5uRLf8BiD0pw085KcS5ZuOIYtXvrk2h xC1piJOgfNQQnCAriV4GOKlcoC6cJxHRIT8r7l+WQEyxTkBI7k+WWhWGTYtBC8mEB1uPLxy saFkFI5B5+is0aETd2YkSuHn+6j5yuL4f1r3ovWZJvFMSTMvdBKXMw2yBiNTSK79GaDhIxF a7JXcWFUM++18wkyxeybQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:gLOUVRVe7LI=:8mTCi493aMUN4LE1cGv5WF SgWNG3f95CA4PpDQ+6GuegOhC5bOdT2ThwIbHlSMsKZgGzXLCouk9cOrxFTtxkTjWY4uM/peX RPGbjtvyyBnrPjGRO9fRpjjCPTuaHIO/WDZCXBHjStLbp7FANWDuseOTXMfev26sQqZ2aF8ZQ gpLf/jYXuLly8MX2KAW3y/hKkaQsYr/ymciggr+/jRwz3bIQjQUYbcY6gQ8WVlK9B/wGva3Bc iX25o2A+8MDG3rnhZFHHdoHwamwqE/5z9B90V9qX4+9pxnr0UHrfBbwAnGfdhvkavb0tcRaU9 eujlWSFHUeU7yuWDNstCZ8e+ON3qHrdckOPJsJGC2P4mLro5/hnjZPbOOra3NG4eNZ1xPOk4u trvhmbGMKY1bJcU21RqVuIWvj037c47mDwvE04f4P6d/xDkEmpgDh1foUxNNBHZkubQ7rttLY I0Ngp2iflOsaxli8LQeAzAmWA0WjsE9ew56SeI4HfscF32bDdNZSLP1VoWGIxYvNg0DNO3zVD HcOWLIgf13LIRypcrWlcQto+oXL7mA7L50ux3+zyO+mViI6GRp7VQ/u5PX8Zfj2tMwq7JzdSL jcbgBNBLpLkh60dB9vopLSc/gks/gsZdrU73pI2nVribcZbDCu4EBe3EiDjQk25eo9CfAcGyz 0rN7lFB27cT01tTaNfvwEwWyRwe6dseIEDY4J919XbJFpArYAY07OzSB/4aHKEdWOb4Sjbm84 cNB4aSf03sWAO8wtUniWjuS1qN8nHDsImtRgxMNjlIX8fa9HdgV5p/mI1JKuZkwUd1MD9IthP NEgckak Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 16 Apr 2017 21:45:38 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvneta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 46fa74e93814..9c9eed5a8e28 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -3992,8 +3992,7 @@ static int mvneta_init(struct device *dev, struct mvneta_port *pp) /* Set port default values */ mvneta_defaults_set(pp); - pp->txqs = devm_kcalloc(dev, txq_number, sizeof(struct mvneta_tx_queue), - GFP_KERNEL); + pp->txqs = devm_kcalloc(dev, txq_number, sizeof(*pp->txqs), GFP_KERNEL); if (!pp->txqs) return -ENOMEM; @@ -4005,8 +4004,7 @@ static int mvneta_init(struct device *dev, struct mvneta_port *pp) txq->done_pkts_coal = MVNETA_TXDONE_COAL_PKTS; } - pp->rxqs = devm_kcalloc(dev, rxq_number, sizeof(struct mvneta_rx_queue), - GFP_KERNEL); + pp->rxqs = devm_kcalloc(dev, rxq_number, sizeof(*pp->rxqs), GFP_KERNEL); if (!pp->rxqs) return -ENOMEM; -- 2.12.2