* [PATCH v3] USB: host: Check for null res pointer
@ 2021-12-20 13:42 Jiasheng Jiang
2021-12-20 16:48 ` Sergey Shtylyov
2021-12-20 16:50 ` Sergey Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Jiasheng Jiang @ 2021-12-20 13:42 UTC (permalink / raw)
To: ok, gregkh, s.shtylyov; +Cc: linux-usb, linux-kernel, Jiasheng Jiang
The return value of platform_get_resource() needs to be checked.
To avoid use of error pointer in case that there is no suitable resource.
Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v2 -> v3
*Change 1. Correct the commit message.
*CHange 2. Change the return code.
---
drivers/usb/host/isp116x-hcd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
index 8835f6bd528e..addd2b43a14c 100644
--- a/drivers/usb/host/isp116x-hcd.c
+++ b/drivers/usb/host/isp116x-hcd.c
@@ -1541,9 +1541,15 @@ static int isp116x_remove(struct platform_device *pdev)
iounmap(isp116x->data_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
+ if (!res)
+ return -ENODEV;
+
release_mem_region(res->start, 2);
iounmap(isp116x->addr_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -ENODEV;
+
release_mem_region(res->start, 2);
usb_put_hcd(hcd);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] USB: host: Check for null res pointer
2021-12-20 13:42 [PATCH v3] USB: host: Check for null res pointer Jiasheng Jiang
@ 2021-12-20 16:48 ` Sergey Shtylyov
2021-12-20 16:50 ` Sergey Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Shtylyov @ 2021-12-20 16:48 UTC (permalink / raw)
To: Jiasheng Jiang, ok, gregkh; +Cc: linux-usb, linux-kernel
On 12/20/21 4:42 PM, Jiasheng Jiang wrote:
> The return value of platform_get_resource() needs to be checked.
> To avoid use of error pointer in case that there is no suitable resource.
s/error/NULL/ -- platform_get_resource() doesn't return error pointers...
> Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] USB: host: Check for null res pointer
2021-12-20 13:42 [PATCH v3] USB: host: Check for null res pointer Jiasheng Jiang
2021-12-20 16:48 ` Sergey Shtylyov
@ 2021-12-20 16:50 ` Sergey Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Shtylyov @ 2021-12-20 16:50 UTC (permalink / raw)
To: Jiasheng Jiang, ok, gregkh; +Cc: linux-usb, linux-kernel
And the subject should look like "usb: host: isp116x: check for NULL pointer".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-20 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 13:42 [PATCH v3] USB: host: Check for null res pointer Jiasheng Jiang
2021-12-20 16:48 ` Sergey Shtylyov
2021-12-20 16:50 ` Sergey Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).