linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Matias Bjørling" <mb@lightnvm.io>
To: hans@owltronix.com
Cc: linux-block@vger.kernel.org, javier@cnexlabs.com,
	linux-kernel@vger.kernel.org, hans.holmberg@cnexlabs.com
Subject: Re: [PATCH] lightnvm: pblk: fix chunk close trace event check
Date: Mon, 29 Oct 2018 12:14:22 +0100	[thread overview]
Message-ID: <35331f13-983b-fb96-3885-f4e617c4adee@lightnvm.io> (raw)
In-Reply-To: <CANr-nt0kcMYrGA5fmG1HBG+Hp6DUwi7B+SWTVfjYtHYE5EGELw@mail.gmail.com>

On 10/29/2018 10:56 AM, Hans Holmberg wrote:
> On Fri, Oct 26, 2018 at 8:49 PM Matias Bjørling <mb@lightnvm.io> wrote:
>>
>> On 10/26/2018 10:12 AM, Hans Holmberg wrote:
>>> The check for chunk closes suffers from an off-by-one issue, leading
>>> to chunk close events not being traced. Fix this.
>>>
>>> Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states")
>>>
>>> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
>>> ---
>>>
>>>    drivers/lightnvm/pblk-core.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>>> index 6944aac43b01..6581c35f51ee 100644
>>> --- a/drivers/lightnvm/pblk-core.c
>>> +++ b/drivers/lightnvm/pblk-core.c
>>> @@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd)
>>>                if (caddr == 0)
>>>                        trace_pblk_chunk_state(pblk_disk_name(pblk),
>>>                                                        ppa, NVM_CHK_ST_OPEN);
>>> -             else if (caddr == chunk->cnlb)
>>> +             else if (caddr == (chunk->cnlb - 1))
>>>                        trace_pblk_chunk_state(pblk_disk_name(pblk),
>>>                                                        ppa, NVM_CHK_ST_CLOSED);
>>>        }
>>>
>>
>> Thanks Hans, Applied for 4.21/5.1. Note that you're sending from your
>> owntronix email account. Checkpatch complains that sender and author
>> doesn't match.
> 
> Ah, I must have messed up my git configuration.
> Would you mind updating the patch author to "Hans Holmberg
> <hans.holmberg@cnexlabs.com>" in for-4.21/core?
> 
> Thanks,
> Hans
> 

Will do. Thanks.

      reply	other threads:[~2018-10-29 11:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26  8:12 [PATCH] lightnvm: pblk: fix chunk close trace event check Hans Holmberg
2018-10-26 18:49 ` Matias Bjørling
2018-10-29  9:56   ` Hans Holmberg
2018-10-29 11:14     ` Matias Bjørling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35331f13-983b-fb96-3885-f4e617c4adee@lightnvm.io \
    --to=mb@lightnvm.io \
    --cc=hans.holmberg@cnexlabs.com \
    --cc=hans@owltronix.com \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).