From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
robh+dt@kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, bkumar@qti.qualcomm.com,
thierry.escande@linaro.org
Subject: Re: [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings
Date: Tue, 11 Dec 2018 09:27:02 +0000 [thread overview]
Message-ID: <3533d3d6-d60f-452f-87bf-d5e89ac1a2bb@linaro.org> (raw)
In-Reply-To: <20181211001050.GA1578@tuxbook-pro>
On 11/12/18 00:10, Bjorn Andersson wrote:
> [..]
>>>> +- reg
>>>> + Usage: required
>>>> + Value type: <u32>
>>>> + Definition: DSP Processor ID.
>>>> + Possible values are :
>>>> + 0 - ADSP
>>>> + 1 - MDSP
>>>> + 2 - SDSP
>>>> + 3 - CDSP
>>> Why is this in a reg?
>> This is to identify which type of dsp(Audio/Modem/Sensor/Compute) it is,
>> This information is used to create device nodes for user-space access.
>>
> But it does not represent FastRPC's address on the rpmsg bus. How about
> replacing it with a "label" (or "qcom,domain" perhaps?) of type string?
Yes, we could replace reg with label in this case. I don't have any
particular preference TBH.
I did try to something similar to "qcom,domain" for apr and Rob H
suggested to use reg instead during review!
thanks,
srini
next prev parent reply other threads:[~2018-12-11 9:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 16:35 [PATCH v2 0/6] misc: Add support to Qualcomm FastRPC driver Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings Srinivas Kandagatla
2018-12-07 18:23 ` Mark Rutland
2018-12-10 11:17 ` Srinivas Kandagatla
2018-12-11 0:10 ` Bjorn Andersson
2018-12-11 9:27 ` Srinivas Kandagatla [this message]
2018-12-11 10:50 ` Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 2/6] misc: fastrpc: Add Qualcomm fastrpc basic driver model Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 3/6] misc: fastrpc: Add support for context Invoke method Srinivas Kandagatla
2018-12-10 14:55 ` kbuild test robot
2018-12-12 11:02 ` Greg KH
2018-12-12 11:14 ` Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 4/6] misc: fastrpc: Add support for create remote init process Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 5/6] misc: fastrpc: Add support for dmabuf exporter Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 6/6] misc: fastrpc: Add support for compat ioctls Srinivas Kandagatla
2018-12-12 10:59 ` Greg KH
2018-12-12 11:44 ` Srinivas Kandagatla
2018-12-12 11:50 ` Greg KH
2018-12-12 12:26 ` Srinivas Kandagatla
2018-12-12 13:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3533d3d6-d60f-452f-87bf-d5e89ac1a2bb@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=bkumar@qti.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.escande@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).