From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754699AbcIJOcm (ORCPT ); Sat, 10 Sep 2016 10:32:42 -0400 Received: from mout.web.de ([212.227.17.11]:62621 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670AbcIJOck (ORCPT ); Sat, 10 Sep 2016 10:32:40 -0400 Subject: [PATCH 7/7] cfag12864b: Adjust two checks for null pointers in cfag12864b_init() To: kernel-janitors@vger.kernel.org, Miguel Ojeda Sandonis References: <566ABCD9.1060404@users.sourceforge.net> <3d24b514-4e99-86ea-d69e-49a0b1edd286@users.sourceforge.net> Cc: LKML , Julia Lawall From: SF Markus Elfring Message-ID: <353dd8b8-9922-8e1b-7c88-9cb425010524@users.sourceforge.net> Date: Sat, 10 Sep 2016 16:32:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3d24b514-4e99-86ea-d69e-49a0b1edd286@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:AVHzPGbRGd4VkEluZ85Wxz/vd6Pre/jg9+u9Q9h03wJY9q5jueJ M/2CElEoGjKZnDKFlPhs4fG4GSeh8584juIz8DY4yrlhAx2U2ecX2PAEy1Xg1eXM4UO30Od IHBn1gGPsYN8wPuQz2kPCbCsJ/D3H4x0WgsMib4r3nibNfXgrMP3PrWbOShXQKeWIRL0ec8 r8sY7WyC4LTU2aeYsYrmw== X-UI-Out-Filterresults: notjunk:1;V01:K0:9EDBDxeiAuU=:rsCH9J44JZxkdfusBmVwHd djYRxR+Nj8KCv1gTnY0J/IpvrtuXmw1nFDIE+Kr+fs0qDnNNzKvY/W8b3bp7/fn59So8jNgeb sw5TRgS0d4Lp4GfrpMCaSXAa+w/qC1mxsy2wGFrG0099NK7rWQMQP0hnR3kYRxrhD3bVwlob1 vG1j962qgfX7YKNfg87hYpdDkL4WNW0rU5I4Pm5w+nn8RustXpMrWs6U2k68WLadiehwDKQss qpkKI7WEQJQYMMdky/lu0+hfp4865GycV3n8XLAb31y5jIE8X86qIWa5T/X7pYzuhhCcsTckk MzUbbrTl2yUABppPTTFx7Pd8kgyhAi7nWGZGkpL0wmLzx9CGjtfIFxVl9pHPC1+ko/8zYL3pS aRlDWrxeJvpbkj8YZqKTJ5jukibBwEgvoJMb2ORN/+XilaDUlIkdGyG0Eht0roXxoXqzw5suP ++AAKVzrLW+m488qlyD74JW7nNJ41iHTuF43koVDPotpnSVJah9wN1Ni6ZIo3oLS7/VtFfX9z Hr12aNnsOVmA83r20mX+4GmSzXHoVfcWQYi9Tz5ckpgv/g2bNdv8x7XiymTF6JCiONDoCSsgb A3Xo9QBIcKMIIKgJSNe3RCPi6Z7xrHVAqLlNZ1LKqcSdVjxvYR3p1shLW4n1nOEOZMXHbM+iX 4/78HtF84yCH4IHcN/bCzNiYgk7pbhkL+eOiJmf/lhrwOYUo99tl4derNd154zvz61SqNJOR+ 64VpTpVoMeIzgY/pC46wUv/j+gU7N7GeM7ytDRO9mQmy/etXwUVdeQ/zLJximHesDf9YVn2lt 4Jbq2eE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 16:06:19 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/auxdisplay/cfag12864b.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c index b2533e2..3956b9f 100644 --- a/drivers/auxdisplay/cfag12864b.c +++ b/drivers/auxdisplay/cfag12864b.c @@ -338,7 +338,7 @@ static int __init cfag12864b_init(void) BUILD_BUG_ON(PAGE_SIZE < CFAG12864B_SIZE); cfag12864b_buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL); - if (cfag12864b_buffer == NULL) { + if (!cfag12864b_buffer) { printk(KERN_ERR CFAG12864B_NAME ": ERROR: " "can't get a free page\n"); return -ENOMEM; @@ -351,7 +351,7 @@ static int __init cfag12864b_init(void) goto free_buffer; cfag12864b_workqueue = create_singlethread_workqueue(CFAG12864B_NAME); - if (cfag12864b_workqueue == NULL) + if (!cfag12864b_workqueue) goto free_cache; cfag12864b_clear(); -- 2.10.0