From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754843AbcFGNZn (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 09:25:43 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:49217 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751973AbcFGNZl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 09:25:41 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, Bjorn Helgaas <bhelgaas@google.com>,
        linux-pci@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Jason Cooper <jason@lakedaemon.net>,
        Scott Branden <sbranden@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>, Jingoo Han <jingoohan1@gmail.com>,
        Pratyush Anand <pratyush.anand@gmail.com>,
        linux-kernel@vger.kernel.org, rfi@lists.rocketboards.org,
        linux-renesas-soc@vger.kernel.org, Simon Horman <horms@verge.net.au>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tanmay Inamdar <tinamdar@apm.com>, Ray Jui <rjui@broadcom.com>,
        linux-tegra@vger.kernel.org, Ley Foon Tan <lftan@altera.com>,
        Michal Simek <michal.simek@xilinx.com>,
        =?ISO-8859-1?Q?S=F6ren?= Brinkmann <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH v1 00/25] PCI: Request host bridge window resources
Date: Tue, 07 Jun 2016 15:25:46 +0200
Message-ID: <3552943.lb56sJA8nL@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20160607131105.GA2543@localhost>
References: <20160606225630.20936.77349.stgit@bhelgaas-glaptop2.roam.corp.google.com> <3416214.BpvATlfaN7@wuerfel> <20160607131105.GA2543@localhost>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:C1WciNfhE1U99c8/d7omzXC6YMIgISqpqiCu8g2VGC9IWdW/eob
 vXL/+3DQiUdgniIETPw0fLFLaFg4r8BVNwhwP3pZVklWpIaR26AbZXR9+854IYOw07KsJmL
 MjJrBUxSfBu9S66Wpq0TZmJiXWbjyUDlkWfMU4MEgd2qKVbzP3WF9J9VKrExN+znhcihVDs
 j7MSo5yBfaKOSW6fTUpLA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:MP54dzDB+Rw=:FcGzKpwxXuwcX/d5tpVWhz
 1UgrpdEMmVwOoqMe/zpDUwxEQQYMuGsBMiXNMmTa0zfmjxVMRRoNH6IieaSdRPkCYVvZYWik9
 RfYACHq7qJYsBFNFB7FUS5NBdbceoW1KnT9/iw7Y+wFnm7ujyzmKp9VGzjF7ClBM41om2tbCr
 eoZsqzCKObUic8TT6zvHdEvWcs+7O5fd2DQ9CUetGwD+5IixbNywCTnNVE6oH06pPzsJLoBEr
 eN4JBdP7qoY/T8FxxC+KriW1GjxOUO2Ev8WZx2UWrgHl00Pn9rfXtB+aQy0TEiE/p6Hts584W
 u4mHB8x3aw3EtNMKEGpbc9+Zna1JxwIUXdP32Fr4H8yo1BEoqSp3FUiHe4J6dMe6qJnKmms25
 WLsylWo06qpCEDSHiu1nhEK6AAvMy7xCSDzoABM3/3nJfrUWgAHQ8nMwWW/SFKwt7sWEsUGQv
 dXSoS/gWroUG/wuvt9DJStvVgkiKnf6ztnJKiPeCi4HvjVPsQhEymyy4jN6Nzb6yvh9kvgcdt
 eqOMZWViufwp+JvEjGVo6CUFv0srm9km4FLrNqUAmQiYN5232nfTPWdyLgpxqr6mFlfvp4azD
 6H/pr10bZcR4jnMv+Py3L57rfv9/KY0tSmEKFSL4YePwy9Y7vuYpYx1gLwTpQgC7FTSbdsWmZ
 5wRsIDBIW96msKBxqKLWPUOizH5WEFijXZ6VhqXv/ihrukRkTogBBaEX2HP7Bjc48e4ZPADVx
 cs2EAs16Mmyt4Plg
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, June 7, 2016 8:11:05 AM CEST Bjorn Helgaas wrote:
> > 
> > What do you think is the correct behavior here, should the driver only
> > request the PIO range with parent=ioport_resource, or should it also
> > request the MMIO window for the I/O ports with parent=iomem_resource?
> > In the latter case, any idea how that can be generalized?
> 
> I think it should request both because I think iomem_resource should
> contain everything in the memory map.  This would be required if we ever
> did any significant reassignment of top-level devices, e.g., ACPI devices.

Ok. Should we try to pass the mmio resource for the I/O window to
the devm_request_pci_bus_resources() function along with the other
arguments then?

As far as I can tell, it should not go into the resource list
because it is not something the PCI core code should access the
way it handles the other resources.

	Arnd