RE: [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell

From: Marc Zyngier <maz@kernel.org>
To: Yash Shah <yash.shah@sifive.com>
Cc: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	<aou@eecs.berkeley.edu>, <jason@lakedaemon.net>,
	<atish.patra@wdc.com>, Sachin Ghadi <sachin.ghadi@sifive.com>,
	<linus.walleij@linaro.org>, <linux-kernel@vger.kernel.org>,
	<bgolaszewski@baylibre.com>, <robh+dt@kernel.org>,
	<palmer@dabbelt.com>, Sagar Kadam <sagar.kadam@sifive.com>,
	<linux-gpio@vger.kernel.org>,
	"Paul Walmsley ( Sifive)" <paul.walmsley@sifive.com>,
	<tglx@linutronix.de>, <bmeng.cn@gmail.com>,
	<linux-riscv@lists.infradead.org>
Subject: RE: [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell
Date: Thu, 21 Nov 2019 09:20:18 +0000	[thread overview]
Message-ID: <35606a5012643fcc71592ab4e2c3fdd5@www.loen.fr> (raw)
In-Reply-To: <CH2PR13MB336857C8AAC4CD3EB48942BF8C4E0@CH2PR13MB3368.namprd13.prod.outlook.com>

On 2019-11-21 08:55, Yash Shah wrote:

[...]

>> > > + * bindings where the cell values map directly to the hwirq 
>> number.
>> > > + */
>> > > +int irq_domain_translate_onecell(struct irq_domain *d,
>> > > +				 struct irq_fwspec *fwspec,
>> > > +				 unsigned long *out_hwirq,
>> > > +				 unsigned int *out_type)
>> > > +{
>> > > +	if (WARN_ON(fwspec->param_count < 1))
>> > > +		return -EINVAL;
>> > > +	*out_hwirq = fwspec->param[0];
>> > > +	*out_type = IRQ_TYPE_NONE;
>> > > +	return 0;
>> > > +}
>> > > +EXPORT_SYMBOL_GPL(irq_domain_translate_onecell);
>> > > +
>> > > +/**
>> > >   * irq_domain_translate_twocell() - Generic translate for 
>> direct
>> > > two cell
>> > >   * bindings
>> > >   *
>> >
>> > Can you please also update (potentially in a separate patch) the
>> > potential users of this? I mentioned the nvic driver last time...
>> >
>>
>> Ok, I will separate out this patch from the patchset and send it 
>> individually
>> along with potential users of it.
>> Thanks for your comments
>
> I am sorry, I think I misunderstood you.
> You want me to send a new separate patch in which the potential users
> will be updated to this new function.
> Hope I got it right?

Just add, as part of this series, a patch that updates the one or two
drivers that could make use of this. It doesn't need to be in a 
separate
patch set (which would cause dependency issues).

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...