From: Marc Zyngier <maz@kernel.org>
To: Yash Shah <yash.shah@sifive.com>
Cc: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<aou@eecs.berkeley.edu>, <jason@lakedaemon.net>,
<atish.patra@wdc.com>, Sachin Ghadi <sachin.ghadi@sifive.com>,
<linus.walleij@linaro.org>, <linux-kernel@vger.kernel.org>,
<bgolaszewski@baylibre.com>, <robh+dt@kernel.org>,
<palmer@dabbelt.com>, Sagar Kadam <sagar.kadam@sifive.com>,
<linux-gpio@vger.kernel.org>,
"Paul Walmsley ( Sifive)" <paul.walmsley@sifive.com>,
<tglx@linutronix.de>, <bmeng.cn@gmail.com>,
<linux-riscv@lists.infradead.org>
Subject: RE: [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell
Date: Thu, 21 Nov 2019 09:20:18 +0000 [thread overview]
Message-ID: <35606a5012643fcc71592ab4e2c3fdd5@www.loen.fr> (raw)
In-Reply-To: <CH2PR13MB336857C8AAC4CD3EB48942BF8C4E0@CH2PR13MB3368.namprd13.prod.outlook.com>
On 2019-11-21 08:55, Yash Shah wrote:
[...]
>> > > + * bindings where the cell values map directly to the hwirq
>> number.
>> > > + */
>> > > +int irq_domain_translate_onecell(struct irq_domain *d,
>> > > + struct irq_fwspec *fwspec,
>> > > + unsigned long *out_hwirq,
>> > > + unsigned int *out_type)
>> > > +{
>> > > + if (WARN_ON(fwspec->param_count < 1))
>> > > + return -EINVAL;
>> > > + *out_hwirq = fwspec->param[0];
>> > > + *out_type = IRQ_TYPE_NONE;
>> > > + return 0;
>> > > +}
>> > > +EXPORT_SYMBOL_GPL(irq_domain_translate_onecell);
>> > > +
>> > > +/**
>> > > * irq_domain_translate_twocell() - Generic translate for
>> direct
>> > > two cell
>> > > * bindings
>> > > *
>> >
>> > Can you please also update (potentially in a separate patch) the
>> > potential users of this? I mentioned the nvic driver last time...
>> >
>>
>> Ok, I will separate out this patch from the patchset and send it
>> individually
>> along with potential users of it.
>> Thanks for your comments
>
> I am sorry, I think I misunderstood you.
> You want me to send a new separate patch in which the potential users
> will be updated to this new function.
> Hope I got it right?
Just add, as part of this series, a patch that updates the one or two
drivers that could make use of this. It doesn't need to be in a
separate
patch set (which would cause dependency issues).
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2019-11-21 9:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 6:59 [PATCH v2 0/5] GPIO & Hierarchy IRQ support for HiFive Unleashed Yash Shah
2019-11-20 6:59 ` [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell Yash Shah
2019-11-20 9:34 ` Thomas Gleixner
2019-11-20 10:24 ` Marc Zyngier
2019-11-20 10:48 ` Thomas Gleixner
2019-11-20 10:38 ` Marc Zyngier
2019-11-21 8:35 ` Yash Shah
2019-11-21 8:55 ` Yash Shah
2019-11-21 9:20 ` Marc Zyngier [this message]
2019-11-20 6:59 ` [PATCH v2 2/5] irqchip: sifive: Support hierarchy irq domain Yash Shah
2019-11-22 10:17 ` Marc Zyngier
2019-11-20 6:59 ` [PATCH v2 3/5] gpio: sifive: Add DT documentation for SiFive GPIO Yash Shah
2019-11-20 6:59 ` [PATCH v2 4/5] gpio: sifive: Add GPIO driver for SiFive SoCs Yash Shah
2019-11-20 10:01 ` Bartosz Golaszewski
2019-11-21 8:32 ` Yash Shah
2019-11-20 6:59 ` [PATCH v2 5/5] riscv: dts: Add DT support for SiFive FU540 GPIO driver Yash Shah
2019-11-20 9:14 ` Andreas Schwab
2019-11-21 8:26 ` Yash Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35606a5012643fcc71592ab4e2c3fdd5@www.loen.fr \
--to=maz@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=bgolaszewski@baylibre.com \
--cc=bmeng.cn@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=sagar.kadam@sifive.com \
--cc=tglx@linutronix.de \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).