From: liuxiang <liuxiang_1999@126.com>
To: "Boris Brezillon" <boris.brezillon@bootlin.com>
Cc: "Liu Xiang" <liu.xiang6@zte.com.cn>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
han.xu@nxp.com, marek.vasut@gmail.com, dwmw2@infradead.org,
computersforpeace@gmail.com, richard@nod.at,
"Yogesh Narayan Gaur" <yogeshnarayan.gaur@nxp.com>
Subject: Re:Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
Date: Mon, 27 Aug 2018 23:02:29 +0800 (CST) [thread overview]
Message-ID: <3571f5ca.c32c.1657be858d1.Coremail.liuxiang_1999@126.com> (raw)
In-Reply-To: <20180827100613.78823993@bbrezillon>
Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc: stable@vger.kernel.org
Should I send a V2 patch that adds these above?
At 2018-08-27 16:06:13, "Boris Brezillon" <boris.brezillon@bootlin.com> wrote:
>On Sat, 18 Aug 2018 17:14:23 +0800
>Liu Xiang <liu.xiang6@zte.com.cn> wrote:
>
>> If the size of spi-nor flash is larger than 16MB, the read_opcode
>> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
>> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
>> cause read operation fail.
>>
>> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
>
>I'm pretty sure you want to backport this fix. Can you add a Fixes tag
>and CC stable?
>
>Also, I'd like to have an Ack from someone working at NXP (Han,
>Yogesh?).
>
>Thanks,
>
>Boris.
>
>> ---
>> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
>> index 7d9620c..64304a3 100644
>> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
>> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
>> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>> {
>> switch (cmd) {
>> case SPINOR_OP_READ_1_1_4:
>> + case SPINOR_OP_READ_1_1_4_4B:
>> return SEQID_READ;
>> case SPINOR_OP_WREN:
>> return SEQID_WREN;
next prev parent reply other threads:[~2018-08-27 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 9:14 [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB Liu Xiang
2018-08-27 8:06 ` Boris Brezillon
2018-08-27 15:02 ` liuxiang [this message]
2018-08-27 15:20 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3571f5ca.c32c.1657be858d1.Coremail.liuxiang_1999@126.com \
--to=liuxiang_1999@126.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=liu.xiang6@zte.com.cn \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).