From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718AbeCMOJk (ORCPT ); Tue, 13 Mar 2018 10:09:40 -0400 Received: from foss.arm.com ([217.140.101.70]:38874 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbeCMOJj (ORCPT ); Tue, 13 Mar 2018 10:09:39 -0400 Cc: Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] cpufreq: scmi: add thermal dependency To: Arnd Bergmann , "Rafael J. Wysocki" , Viresh Kumar References: <20180313114607.2061209-1-arnd@arndb.de> <20180313114607.2061209-2-arnd@arndb.de> From: Sudeep Holla Organization: ARM Message-ID: <357f8fbd-d079-8b75-aec6-96e59f5a9556@arm.com> Date: Tue, 13 Mar 2018 14:09:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180313114607.2061209-2-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/18 11:45, Arnd Bergmann wrote: > A built-in scmi cpufreq driver cannot link against a modular > thermal framework: > > drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_ready': > scmi-cpufreq.c:(.text+0x40): undefined reference to `of_cpufreq_cooling_register' > drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_exit': > scmi-cpufreq.c:(.text+0x88): undefined reference to `cpufreq_cooling_unregister' > > This adds a Kconfig dependency that makes sure this configuration > is not possible, while allowing all configurations that can work. > Note that disabling CPU_THERMAL means we don't care about the > THERMAL dependency. > This newly added entry is only in arm-soc linux-next. Let me know if you want pull request with other possible fixes or you want to merge directly as it might be need to suppress these errors in your build system. For now I assume you will merge this directly in your tree, so Acked-by: Sudeep Holla -- Regards, Sudeep