From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbdHAMqQ (ORCPT ); Tue, 1 Aug 2017 08:46:16 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56573 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdHAMqO (ORCPT ); Tue, 1 Aug 2017 08:46:14 -0400 X-AuditID: b6c32a38-f799e6d000004f48-91-59807814a381 From: Bartlomiej Zolnierkiewicz To: "Gustavo A. R. Silva" Cc: Michal Simek , =?ISO-8859-1?Q?S=F6ren?= Brinkmann , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures Date: Tue, 01 Aug 2017 14:46:09 +0200 Message-id: <3588026.hdL4GfIT2C@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170708012416.GA1843@embeddedgus> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42LZdljTQFekoiHSYNcTaYuVS/azWWx6fI3V 4kTfB1aLy7vmsFm8exlhcXPHZnYHNo91B1U9Ni+p9/i8Sc5j7+ffLAEsUVw2Kak5mWWpRfp2 CVwZL69LFexjr2icrtfA+IK1i5GDQ0LAROLGu9ouRk4gU0ziwr31bCC2kMAORonNCwK6GLmA 7M+MEn+PLmeFKDKRmPy/mw0iAVR0ct05RgjnK6PE7zVbwdrZBKwkJravYgSxRQSMJa4938cE UsQscIFRYlnbXhaQ1cICyRIfPgqC1LAIqEoc2LSfBcTmFdCU2HN3Btg2UQEviS372plAbE4B A4ljp+YxQ9QISvyYfA+snllAXmLf/qmsELaOxNlj68AOkhCYzi5xrGU1C8SbshKbDjBDfOAi 8ebfGShbWOLV8S3sELaUROPLh0wQ9nRGie2/JSDmbGaUWLV7AlSRtcTh4xehlvFJvPvaAw1G XomONiGIEg+JRY+nQM13lJjcPJ0FEkDNjBJz9u5jncAoPwvJD7OQ/DALyQ8LGJlXMYqlFhTn pqcWGxaY6BUn5haX5qXrJefnbmIEJw0tix2Me875HGIU4GBU4uHtMK2PFGJNLCuuzD3EKMHB rCTCW1XWECnEm5JYWZValB9fVJqTWnyIUZqDRUmcV3T9tQghgfTEktTs1NSC1CKYLBMHp1QD Y6FGJkP7w6D0hdvUcs4qar39eUFiwUfv1YpqRxduWMqRX1awwJTVhc9bstKz7oNBZ5sVm4f9 rv7kjfc/xy5j3/pIeM6bZuP7Vuycs/sjth37uKxzk/GJPZmTboao/+F8+2tah8/mtRNfWL35 nM1WzPHq0VphV/0+qdf9XfzyXa3P9cPOTZ2lpsRSnJFoqMVcVJwIAIobEI8WAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsVy+t9jAV2RioZIg4nN3BYrl+xns9j0+Bqr xYm+D6wWl3fNYbN49zLC4uaOzewObB7rDqp6bF5S7/F5k5zH3s+/WQJYotxsMlITU1KLFFLz kvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CW8fK6VME+ 9orG6XoNjC9Yuxg5OSQETCQm/+9mg7DFJC7cWw9kc3EICWxjlFh9/jVYQkjgK6PEnm/aIDab gJXExPZVjCC2iICxxLXn+5hAGpgFLjFKdL37ydzFyMEhLJAs8eGjIEgNi4CqxIFN+1lAbF4B TYk9d2eALRYV8JLYsq+dCcTmFDCQOHZqHjPE4lZGiR0fJ7FBNAhK/Jh8D6yZWUBeYt/+qawQ tpbE+p3HmSYwCsxCUjYLSdksJGULGJlXMYqlFhTnpucWGxUY6hUn5haX5qXrJefnbmIExtC2 w1r+Oxh/nI0+xCjAwajEw9sh1hApxJpYVlyZe4hRgoNZSYS3qgwoxJuSWFmVWpQfX1Sak1p8 iNEU6L+JzFKiyfnA+M4riTc0sTQyMTAzMzQyMDZTEuedEPglQkggPbEkNTs1tSC1CKaPiYNT qoEx5N7k606n7fLu5h55lyDFLLv5hkZ6+dTbz5VVbGXqs1XfBp2NXr9Otfz040eBs1Y/qOv2 uJUwecGMn7FCZjO+WdQdOmG8q3jv584N/EWbJq+/tPrIidvZ5gdWsHlMSfy0IH5VAjPj5cc3 nya5+Sv+vuwiuH3jv0dvnuvt5Vu18Eng+tw9VlfVpyqxFGckGmoxFxUnAgABl3+otwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170801124612epcas1p186eef62f44bcf8df8cef736c03c89f34 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170708012420epcas4p3f5cc06fb74847c659e28a80d405f77a0 X-RootMTR: 20170708012420epcas4p3f5cc06fb74847c659e28a80d405f77a0 References: <20170708012416.GA1843@embeddedgus> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 07, 2017 08:24:16 PM Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct fb_fix_screeninfo i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct fb_fix_screeninfo e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct fb_fix_screeninfo i = { ... }; > > The semantic patch for fb_var_screeninfo is analogous. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics