From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B300EC74A5B for ; Tue, 21 Mar 2023 13:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbjCUN1p (ORCPT ); Tue, 21 Mar 2023 09:27:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbjCUN1m (ORCPT ); Tue, 21 Mar 2023 09:27:42 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F9F84ECCD for ; Tue, 21 Mar 2023 06:27:12 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id t17-20020a05600c451100b003edc906aeeaso727697wmo.1 for ; Tue, 21 Mar 2023 06:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679405231; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=nmuE9i4BOGv8wbGqII05vBX2hvOFUNZmklG6jr67aGk=; b=TWUgzxiNQuNvs7HKZcuVl11DJ1mctEQVxFLCpudW0tHRvL0lXGjm+4L6Z2fiaI/kMt xI+L3BVymVEMvaQK8wSVmHvCH9quIyRsWF1gknYrMmNvvLG3ETJtwVl2mPgLUQ6v2fc4 djM+OmxrRuie9OnzKX+gOmRYv2OJnFTzDHBWw/H2/TrZxeW8qddUCFCHytTBZGotJxUH xudE6MwyuMnO4yDx/jwRvxDZcgI5h5zo28nlnmZTaCFgIbKmxEK9crSUkF2ej13pjdU2 rNhaVogcHF+Keavw1r2sOJYFlXOcCzPT7BL9CL2wTQQnsqRtDOzrujTEwvjA3lS//L8Q 2jjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679405231; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nmuE9i4BOGv8wbGqII05vBX2hvOFUNZmklG6jr67aGk=; b=6MBseg2PgMmt8eeTvCE6eSB1Bz89H5/E4FK+sYkWiHT/XBRKIblUwvwUKpuN/yKIIx YJ/UC0SiJ7GqhtTuXDc+O+dLxq4f5iY+XScnqnpPc8YHv6pEKU838gDy7yHZlxg/CN0Z 2RMi+3Vz3SskJ+vF2seutklF0xVIysYpa4MKFGvwXCFrfl6nUNWyIknytzl1bXqgsJCS ySmdUTMfF10gnGy/sjBbH6qnzg9Er2iRLMSMS/ElFr4tRkt1KtJZnoy/L4qjEpIAD7W7 Qe8AzmMlnrNNLAPNQ4Srk4K7HDrP/sH2vcPRmqHwYv0+6qeNIftNccTXn0iSYRLGU1As QL+Q== X-Gm-Message-State: AO0yUKVaYtWtlML4OXrFvGUgSVnvVulUs6bCGz9opW/eV2VQvfWAqQN8 uoMrbxwfblG3vZRQi19bPP2dCA== X-Google-Smtp-Source: AK7set9+2mXnERPRLq+QIR9/XRsWTj2Mg5s8G1jTh6AI8V1S7SD/6C6xUGT5J2z1GE5KNYG1w8JPug== X-Received: by 2002:a05:600c:28d3:b0:3ed:2eb5:c2dd with SMTP id h19-20020a05600c28d300b003ed2eb5c2ddmr2133002wmd.39.1679405230793; Tue, 21 Mar 2023 06:27:10 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:c8ed:7915:30cc:f830? ([2a01:e0a:982:cbb0:c8ed:7915:30cc:f830]) by smtp.gmail.com with ESMTPSA id c12-20020a05600c0a4c00b003eda357cfc5sm11232426wmq.43.2023.03.21.06.27.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 06:27:09 -0700 (PDT) Message-ID: <35aa4401-8b35-09b5-9d97-59867d1df15c@linaro.org> Date: Tue, 21 Mar 2023 14:27:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] drm/meson: fix missing component unbind on bind errors Content-Language: en-US To: Johan Hovold , Martin Blumenstingl Cc: Johan Hovold , David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230306103533.4915-1-johan+linaro@kernel.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/03/2023 14:14, Johan Hovold wrote: > On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote: > >> On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold wrote: >> [...] >>> @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) >>> >>> ret = meson_encoder_hdmi_init(priv); > >> I'm wondering if component_bind_all() can be moved further down. >> Right now it's between meson_encoder_cvbs_init() and >> meson_encoder_hdmi_init(). So it seems that encoders don't rely on >> component registration. > > Perhaps it can, but that would be a separate change (unless there is > something inherently wrong with the current initialisation order). The CVBS doesn't rely on any components unlike HDMI, this explains the current position of component_bind_all(). > >> Unfortunately I am also not familiar with this and I'm hoping that >> Neil can comment on this. > > Any comments on this one, Neil? Yep, components should be bind for HDMI encoder/bridge init. Anyway for this patch, sorry for the delay, but it's looks fine: Acked-by: Neil Armstrong > > Johan