From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, lukasz.luba@arm.com
Subject: Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system
Date: Sun, 28 Mar 2021 20:01:54 +0200 [thread overview]
Message-ID: <35b543d1-5559-b814-11b0-8a53c1218750@linaro.org> (raw)
In-Reply-To: <YGC8Yj9OTgc4aU0y@kroah.com>
On 28/03/2021 19:26, Greg KH wrote:
[ ... ]
>>> So why are you trying to add a kref here as the structure already has
>>> support for proper lifetimes?
>>
>> Right, I'll revisit that part. Thanks for the review.
>>
>> I've a branch which is pulled by Rafael [1]. These parts are already
>> merged in the dtpm/next branch but not yet in Rafael's tree.
>
> I would recommend fixing that up if you can rebase it. If not, you need
> to revert it and start over. I'll be glad to review it if you cc: me on
> the patches.
>
>> I think a rebase is possible but I would like to avoid that. Would be a
>> patch on top of the dtpm/next acceptable given your flow with Android ?
>
> This has nothing to do with the Android kernel workflow, sorry. I am
> concerned about proper kernel development and keeping bugs out of it.
Fair enough, I will fix it up and send a v5.
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-03-28 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 13:04 [PATCH v4 1/5] powercap/drivers/dtpm: Encapsulate even more the code Daniel Lezcano
2021-03-12 13:04 ` [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system Daniel Lezcano
2021-03-27 12:50 ` Greg KH
2021-03-27 19:41 ` Daniel Lezcano
2021-03-28 6:50 ` Greg KH
2021-03-28 11:11 ` Daniel Lezcano
2021-03-28 11:24 ` Greg KH
2021-03-28 16:07 ` Daniel Lezcano
2021-03-28 17:26 ` Greg KH
2021-03-28 18:01 ` Daniel Lezcano [this message]
2021-03-12 13:04 ` [PATCH v4 3/5] powercap/drivers/dtpm: Simplify the dtpm table Daniel Lezcano
2021-03-12 13:04 ` [PATCH v4 4/5] powercap/drivers/dtpm: Use container_of instead of a private data field Daniel Lezcano
2021-03-12 13:04 ` [PATCH v4 5/5] powercap/drivers/dtpm: Scale the power with the load Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b543d1-5559-b814-11b0-8a53c1218750@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).