From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D9F0C27C76 for ; Wed, 25 Jan 2023 11:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234833AbjAYLXh (ORCPT ); Wed, 25 Jan 2023 06:23:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235222AbjAYLX3 (ORCPT ); Wed, 25 Jan 2023 06:23:29 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 072D2CDCF for ; Wed, 25 Jan 2023 03:23:01 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id j17so13517665wms.0 for ; Wed, 25 Jan 2023 03:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xt+vl8rRw5mhg9gfkhmLGr4GRspht5UpB/9onW75LaE=; b=BLl2mNa5aGjjxsJq1wZmB5eFoLyRartRXEMVboY6qbP5509ml87YnB8ErfWLwPLIr9 nW8M6MP8YEDR+ayPIX4+PGl+rOkCg3adnRrw86QVvPOEbEFGOWYmq2zbzbbpGNapu12x OPV77Dl5fA0OAfMRc5ebfhl4kB0vmf5cBAXi9K7wEQmV9h8FN9kn2Us0Og/24NlO9dmi k2+GVWyaeTK3nfVjJM3iF2+KWNLCbuNDuLPy3RJUGFtPMimrWIyLjXPlmEpEXYMC0zuu YuM5qJ4ZPdDLraf327lpxQwusoI5nmUyA8huCj8kUs03dvvklLDcnBxXfXa7Nx2oej3o a2KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xt+vl8rRw5mhg9gfkhmLGr4GRspht5UpB/9onW75LaE=; b=ziwsIvu4q015OTit715uANYV5exS6RVX6QNCYL9yqWmB3qpXDoG3HSLHb7FHuae0Vw i4WoUjyrgTIRYpzh3nK6b3ugtxLDTcBmqP1C+K/11CNZRnIw5sg1fr2tozWrZ1Ibd2AK KaETiKeiSHbw40KDq69+Sy36hI6+B/d66vumaTwA9qyRVfg3QlPC8BdEKGWocQ1Jr+Fo rC8xHIa4pqVMxiagFELa6hzvYXQf07JB/JsbRIfw+EgBNvGC0alFBSCBCRR15IEqbQI3 RabuWACTt1qVbrYTYcpS2q2yh5c4pKadkJC21DG8gLdIVIFpLoesDP6Tozz7gLhznUM8 Kk/w== X-Gm-Message-State: AFqh2krnGg7qDSNxUDpq8AaBkHux6fpTqEsJ/ff/PZPSUpyH4HvTlhwr 065Bl703hyNePgdund2T867ejA== X-Google-Smtp-Source: AMrXdXvSRVYEmr+rYW5N2QSJPfvb+oS7O+VkdsbDRAgHsvTy2hrXGU/hmovUFz7prV/hc4w2991iWA== X-Received: by 2002:a05:600c:3b18:b0:3db:eab:3c5c with SMTP id m24-20020a05600c3b1800b003db0eab3c5cmr28597769wms.32.1674645780086; Wed, 25 Jan 2023 03:23:00 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t19-20020a1c7713000000b003c71358a42dsm1872933wmi.18.2023.01.25.03.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 03:22:59 -0800 (PST) Message-ID: <35bb0017-7ffc-d128-17be-4b9c14aace26@linaro.org> Date: Wed, 25 Jan 2023 12:22:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 09/10] arm64: dts: qcom: add IPQ5332 SoC and MI01.2 board support Content-Language: en-US To: Kathiravan Thirumoorthy , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, broonie@kernel.org, robimarko@gmail.com, quic_gurus@quicinc.com, bhupesh.sharma@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230125104520.89684-1-quic_kathirav@quicinc.com> <20230125104520.89684-10-quic_kathirav@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230125104520.89684-10-quic_kathirav@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2023 11:45, Kathiravan Thirumoorthy wrote: > From: Kathiravan T > > Add initial device tree support for the Qualcomm IPQ5332 SoC and > MI01.2 board. > > Signed-off-by: Kathiravan T > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 71 +++++ > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 273 ++++++++++++++++++++ > 3 files changed, 345 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts > create mode 100644 arch/arm64/boot/dts/qcom/ipq5332.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 3e79496292e7..fbd5bc583a9b 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -3,6 +3,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb > +dtb-$(CONFIG_ARCH_QCOM) += ipq5332-mi01.2.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb > diff --git a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts > new file mode 100644 > index 000000000000..7984d8f824ce > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts > @@ -0,0 +1,71 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) A bit odd license (accepting GPLv3...), especially that DTSI is only BSD. Was it really intended? > +/* > + * IPQ5332 AP-MI01.2 board device tree source > + * > + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "ipq5332.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. IPQ5332/AP-MI01.2"; Just to be clear - you indicated in bindings that "AP" is the foundry ID. This is correct, right? Then I am not sure if it should be in model name. > + compatible = "qcom,ipq5332-ap-mi01.2", "qcom,ipq5332"; > + > + aliases { > + serial0 = &blsp1_uart0; > + }; > + > + chosen { > + stdout-path = "serial0"; > + }; > +}; > + > +&blsp1_uart0 { > + pinctrl-0 = <&serial_0_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&sdhc { > + pinctrl-0 = <&sdc_default_state>; > + pinctrl-names = "default"; > + non-removable; > + status = "okay"; > +}; > + > +&sleep_clk { > + clock-frequency = <32000>; > +}; > + > +&xo_board { > + clock-frequency = <24000000>; > +}; > + > +/* PINCTRL */ > + > +&tlmm { > + sdc_default_state: sdc-default-state { > + clk-pins { > + pins = "gpio13"; > + function = "sdc_clk"; > + drive-strength = <8>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "gpio12"; > + function = "sdc_cmd"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + data-pins { > + pins = "gpio8", "gpio9", "gpio10", "gpio11"; > + function = "sdc_data"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > new file mode 100644 > index 000000000000..d04244a3cd3a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -0,0 +1,273 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * IPQ5332 device tree source > + * > + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#include > +#include > + > +/ { > + interrupt-parent = <&intc>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + clocks { > + sleep_clk: sleep-clk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; > + > + xo_board: xo-board-clk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; > + }; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + CPU0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x0>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + > + CPU1: cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x1>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + > + CPU2: cpu@2 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x2>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + > + CPU3: cpu@3 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x3>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + > + L2_0: l2-cache { > + compatible = "cache"; > + cache-level = <0x2>; This is just "2", not hex. > + }; > + }; > + > + firmware { > + scm { > + compatible = "qcom,scm-ipq5332", "qcom,scm"; > + }; > + }; > + > + memory@40000000 { > + device_type = "memory"; > + /* We expect the bootloader to fill in the size */ > + reg = <0x0 0x40000000 0x0 0x0>; > + }; > + > + pmu { > + compatible = "arm,cortex-a53-pmu"; > + interrupts = ; > + }; > + > + psci { > + compatible = "arm,psci-1.0"; > + method = "smc"; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + tz: memory@4a600000 { > + no-map; > + reg = <0x0 0x4a600000 0x0 0x200000>; > + }; > + }; > + > + soc@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0 0 0xffffffff>; > + compatible = "simple-bus"; > + > + tlmm: pinctrl@1000000 { > + compatible = "qcom,ipq5332-tlmm"; > + reg = <0x01000000 0x300000>; > + interrupts = ; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&tlmm 0 0 53>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + serial_0_pins: serial0-state { > + pins = "gpio18", "gpio19"; > + function = "blsp0_uart0"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + }; > + > + gcc: clock-controller@1800000 { > + compatible = "qcom,ipq5332-gcc"; > + reg = <0x01800000 0x80000>; > + #clock-cells = <0x1>; > + #reset-cells = <0x1>; > + #power-domain-cells = <1>; > + clock-names = "xo", > + "sleep_clk", > + "pcie_2lane_phy_pipe_clk", > + "pcie_2lane_phy_pipe_clk_x1", > + "usb_pcie_wrapper_pipe_clk"; > + clocks = <&xo_board>, > + <&sleep_clk>, > + <0>, > + <0>, > + <0>; > + }; > + > + sdhc: mmc@7804000 { > + compatible = "qcom,ipq5332-sdhci", "qcom,sdhci-msm-v5"; > + reg = <0x07804000 0x1000>, <0x07805000 0x1000>; > + > + interrupts = , > + ; > + interrupt-names = "hc_irq", "pwr_irq"; > + > + clocks = <&gcc GCC_SDCC1_AHB_CLK>, > + <&gcc GCC_SDCC1_APPS_CLK>, > + <&xo_board>; > + clock-names = "iface", "core", "xo"; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + max-frequency = <192000000>; > + bus-width = <4>; Aren't these five properties of the board? Do you fix the exact eMMC module inside the SoC? > + status = "disabled"; > + }; > + > + blsp1_uart0: serial@78af000 { > + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; > + reg = <0x078af000 0x200>; > + interrupts = ; > + clocks = <&gcc GCC_BLSP1_UART1_APPS_CLK>, > + <&gcc GCC_BLSP1_AHB_CLK>; > + clock-names = "core", "iface"; > + status = "disabled"; > + }; > + > + intc: interrupt-controller@b000000 { > + compatible = "qcom,msm-qgic2"; > + #address-cells = <1>; > + #size-cells = <1>; > + interrupt-controller; > + #interrupt-cells = <0x3>; > + reg = <0x0b000000 0x1000>, /* GICD */ > + <0x0b002000 0x1000>, /* GICC */ > + <0x0b001000 0x1000>, /* GICH */ > + <0x0b004000 0x1000>; /* GICV */ > + interrupts = ; > + ranges = <0 0x0b00c000 0x3000>; > + > + v2m0: v2m@0 { > + compatible = "arm,gic-v2m-frame"; > + reg = <0x0 0xffd>; > + msi-controller; > + }; > + > + v2m1: v2m@1 { > + compatible = "arm,gic-v2m-frame"; > + reg = <0x00001000 0xffd>; > + msi-controller; > + }; > + > + v2m2: v2m@2 { > + compatible = "arm,gic-v2m-frame"; > + reg = <0x00002000 0xffd>; > + msi-controller; > + }; > + }; > + > + timer@b120000 { > + compatible = "arm,armv7-timer-mem"; > + reg = <0x0b120000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + frame@b120000 { > + frame-number = <0>; > + interrupts = , > + ; > + reg = <0x0b121000 0x1000>, > + <0x0b122000 0x1000>; > + }; > + > + frame@b123000 { > + frame-number = <1>; > + interrupts = ; > + reg = <0x0b123000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b124000 { > + frame-number = <2>; > + interrupts = ; > + reg = <0x0b124000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b125000 { > + frame-number = <3>; > + interrupts = ; > + reg = <0x0b125000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b126000 { > + frame-number = <4>; > + interrupts = ; > + reg = <0x0b126000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b127000 { > + frame-number = <5>; > + interrupts = ; > + reg = <0x0b127000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b128000 { > + frame-number = <6>; > + interrupts = ; > + reg = <0x0b128000 0x1000>; > + status = "disabled"; > + }; > + }; > + Drop blank line. > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = , > + , > + , > + ; > + }; > +}; Best regards, Krzysztof